handle return statement inside clsoure #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
small CI fix to be made, lgtm other than that |
stepinto
force-pushed
the
fix_return_in_closure_0913
branch
from
558fef7 to
caaba47
Compare
Contributor
Author
Fixed the build warning. Thank you. |
We should never replace return statements to `break 'run` inside closures. Refer to test case `gl_issue_41` for an example.
stepinto
force-pushed
the
fix_return_in_closure_0913
branch
from
caaba47 to
f65810a
Compare
robjtede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never replace return statements to
break 'runinside closures. Refer to test casegl_issue_41for an example.