This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Handle fragment removal inside of the RemovePage method #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
changed the title
samhouts
approved these changes
Jul 17, 2017
| #endif | ||
|
|
||
| [Preserve(AllMembers = true)] | ||
| [Issue(IssueTracker.None, 0101100101, "PopAsync crashing after RemovePage when support packages are updated to 25.1.1", PlatformAffected.Android)] |
There was a problem hiding this comment.
Binary issue numbers now?
There was a problem hiding this comment.
Could be simplified to 101100101
kingces95
reviewed
Jul 18, 2017
| { | ||
| var test = new Button { Text = StartTest }; | ||
|
|
||
| var instructions = new Label {Text = $"Tap the button labeled '{StartTest}'. The app should navigate to a page displaying the label '{RootLabel}'. If the application crashes, the test has failed." }; |
There was a problem hiding this comment.
What, if any, column length limits do/could/should we have?
kingces95
reviewed
Jul 18, 2017
|
|
||
| // This causes a NullPointerException in API 25.1+ when we later call ExecutePendingTransactions(); | ||
| // We may want to remove this in the future if it is resolved in the Android SDK. | ||
| if ((int)Build.VERSION.SdkInt < 25) |
There was a problem hiding this comment.
Ick. Nice to see this go...
kingces95
approved these changes
Jul 19, 2017
4 tasks
This was referenced Aug 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Now handles fragment removal inside of the
RemovePagemethod rather than leaving it pending forSwitchContentAsyncto deal with later.Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist