This repository was archived by the owner on May 1, 2024. It is now read-only.
[Core] Fixes '0*' RowDefinition/ColumnDefinition in Grid #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
suggested changes
Jun 4, 2018
| if (!row.Height.IsStar) | ||
| continue; | ||
| starRowHeight = Math.Max(starRowHeight, row.ActualHeight / row.Height.Value); | ||
| starRowHeight = row.Height.Value != 0 ? Math.Max(starRowHeight, row.ActualHeight / row.Height.Value) : 0; |
There was a problem hiding this comment.
apply to column as well
paymicro
changed the title
StephaneDelcroix
approved these changes
Jun 5, 2018
|
could you please rebase it on top of 3.1.0 |
StephaneDelcroix
added
the
retarget-branch-required
xamarin-release-manager
added
the
API-change
|
@StephaneDelcroix sure. Done. |
StephaneDelcroix
removed
the
retarget-branch-required
|
@paymicro thx |
jassmith
approved these changes
Jun 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added support 0* RowDefinition in Grid
Bugs Fixed
API Changes
/
Behavioral Changes
RowDefinition"0*" have zero heightPR Checklist