New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] allow namespaces in {x:Type} markups #867

Merged
merged 2 commits into from Apr 20, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Apr 13, 2017

Description of Change

[XamlC] allow namespaces in {x:Type} markups, like in

<Button CommandParameter="{x:Type ns:Foo.Bar}" />

as it's supported with XamlC off

this fixes a regression in 2.3.4

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix requested a review from hartez Apr 18, 2017

@StephaneDelcroix StephaneDelcroix referenced this pull request Apr 18, 2017

Merged

[XamlC] support nested types type declarations #872

4 of 4 tasks complete

@StephaneDelcroix StephaneDelcroix requested a review from jassmith Apr 20, 2017

@StephaneDelcroix StephaneDelcroix merged commit abdad97 into master Apr 20, 2017

6 of 8 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests faile…
Details
Android-UITests-LegacyRenderers Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 (Legacy Rende…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3769, ignored: 11
Details
Windows-Release Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3769, ignored: 11
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-55027 branch Apr 20, 2017

StephaneDelcroix added a commit that referenced this pull request Apr 20, 2017

[XamlC] allow namespaces in {x:Type} markups (#867)
* [XamlC] allow namespaces in {x:Type} markups

* missing test

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.4 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment