[Bug] TouchEffect causes View's stuck if PressedAnimationDuration is set, but NormalAnimationDuration isn't

[gaurakshay]

Hi!

I am trying to understand the difference between TouchEffect.AnimationDuration and TouchEffect.PressedAnimationDuration.

The markup below works fine:

<Frame CornerRadius="30"
       Padding="30, 5"
       HorizontalOptions="CenterAndExpand"
       VerticalOptions="CenterAndExpand"
       xct:TouchEffect.PressedScale="0.9"
       xct:TouchEffect.AnimationDuration="100"
       xct:TouchEffect.AnimationEasing="CubicInOut"
       HasShadow="False"
       BackgroundColor="#0178D4"
       >
    <Grid ColumnDefinitions="Auto, Auto">
        <Label Text="AnimationDuration" FontSize="28" TextColor="White" Padding="0, 10"/>
        <Label Grid.Column="1" Text="&#xf054;" FontFamily="FASolid" FontSize="28" Margin="0,5,0,0" Padding="20,10,0,0" TextColor="White"/>
    </Grid>
</Frame>

However, the markup below causes the animation to be "stuck"

<Frame CornerRadius="30"
       Padding="30, 5"
       HorizontalOptions="CenterAndExpand"
       VerticalOptions="CenterAndExpand"
       xct:TouchEffect.PressedScale="0.9"
       xct:TouchEffect.PressedAnimationDuration="100"
       xct:TouchEffect.AnimationEasing="CubicInOut"
       HasShadow="False"
       BackgroundColor="#0178D4"
       >
    <Grid ColumnDefinitions="Auto, Auto">
        <Label Text="AnimationDuration" FontSize="28" TextColor="White" Padding="0, 10"/>
        <Label Grid.Column="1" Text="&#xf054;" FontFamily="FASolid" FontSize="28" Margin="0,5,0,0" Padding="20,10,0,0" TextColor="White"/>
    </Grid>
</Frame>

SM.G930U.2021-02-24.17-27-24.mp4

Please see the attached screen capture where the button looks like it is stuck when pressed.

I feel like this is more of a misunderstanding on my part rather than a bug which is why I didn't report this as a bug.

[gaurakshay]

Forgot to mention setup details:
Xamarin Forms : 5.0.0.2012
Community Toolkit version : 1.0.3
Android OS : 8.0

[AndreiMisiukevich]

AnimationDuration is applied to both Pressed and Normal state at the same time (if you want the same animation duriation for pressing and releasing transitions)

PressedAnimationDuration is applied only to pressing
NormalAnimationDuration is applied only to releasing

(if you want to have different animation durations)

[gaurakshay]

@AndreiMisiukevich Thanks I understand a little better now. Why does the Frame (on which the TouchEffect is applied) look like it is stuck? Shouldn't it return to its normal state?

[AndreiMisiukevich]

@AndreiMisiukevich Thanks I understand a little better now. Why does the Frame (on which the TouchEffect is applied) look like it is stuck? Shouldn't it return to its normal state?

That's a bug)

[gaurakshay]

@AndreiMisiukevich what I have noticed is that if I keep the element pressed until the pressed animation is over, the element returns back to its normal state. If I press and let go before the animation is over, it stays stuck.

[AndreiMisiukevich]

@AndreiMisiukevich what I have noticed is that if I keep the element pressed until the pressed animation is over, the element returns back to its normal state. If I press and let go before the animation is over, it stays stuck.

Yep) It's fixed. You may verify my PR

[gaurakshay]

Yep) It's fixed. You may verify my PR

Sorry, I want to try the fix but I am getting error building the project on my system (I have never built XamarinCommunityToolkit before so my system configuration might be incorrect)

[pictos]

@gaurakshay probably you're missing some UWP SDK to be able to run our project. Instead of that, you can try this NuGet, which has the bits of Andrei's PR.

[maxkoshevoi]

@gaurakshay Remove all the targets that you don't need. If you only want to test fix on android, do this: