Skip to content
This repository was archived by the owner on Apr 29, 2024. It is now read-only.

Conversation

@PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Feb 22, 2020

Description of Change

Draw is only called once and is not called if the layout of the view changes.

We had an issue logged here
xamarin/Xamarin.Forms#9623

But you can manifest the same issue by changing the orientation on the device.

  • Launch camera sample in portrait
  • rotate to landscape

You will notice that without this change the preview window doesn't resize

Pull Request Checklist

  • Rebased on top of master at time of the pull request.
  • Changes adhere to coding standard in the sample.
  • Consolidated NuGet packages across all projects in the sample (when changing existing package versions).
  • Tested changes on the appropriate platforms (all platforms if changing the library code).

Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PureWeen

@davidbritch davidbritch merged commit d571396 into master Feb 27, 2020
@davidbritch davidbritch deleted the camera_ios_fix branch February 27, 2020 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants