Port to jbuilder and resync with djs55 repo #3
Conversation
Signed-off-by: David Scott <dave@recoil.org>
Add .travis.yml
Signed-off-by: David Scott <dave@recoil.org>
Unfortunately he's not present in `git log | grep Author` because the code was imported from another repository. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Prepare to release v1.0.4
The tuntap test has been separated to a stub package, fd-send-recv-tuntap whose only use is to install the necessary dependency and run the test (using sudo, otherwise the privileges seems not enough to use tuntap). Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
| homepage: "https://github.com/xapi-project/ocaml-fd-send-recv" | ||
| bug-reports: "https://github.com/xapi-project/ocaml-fd-send-recv/issues" | ||
| dev-repo: "https://github.com/xapi-project/ocaml-fd-send-recv.git" | ||
| doc: "https://github.com/xapi-project/ocaml-fd-send-recv/blob/master/lib/fd_send_recv.mli" |
lib/META
Outdated
| # OASIS_START | ||
| # DO NOT EDIT (digest: 0a469b53195f4c578082ce622a25da7c) | ||
| version = "1.0.1" | ||
| # DO NOT EDIT (digest: 464dc1b5e16adf8099f0fd9ceeaaa775) |
There was a problem hiding this comment.
This leftover file should also be removed.
There was a problem hiding this comment.
I think there are some more files that should be removed: lib/fd_send_recv.mllib, lib/libfd_send_recv_stubs.clib.
There was a problem hiding this comment.
Oh, well spotted, I thought I had removed them.
| dev-repo: "https://github.com/xapi-project/ocaml-fd-send-recv.git" | ||
| doc: "https://github.com/xapi-project/ocaml-fd-send-recv/blob/master/lib/fd_send_recv.mli" | ||
| tags: [ | ||
| "org:mirage" |
There was a problem hiding this comment.
It's interesting that we have a separate opam file for the tuntap tests, but I guess this is the best way, since optional dependencies are harmful.
There was a problem hiding this comment.
Yes, it's annoying but I thought it does no harm. And I like it more than generating additional stuff in the jbuild file if a flag is present (mostly because it requires an additional dependency)
There was a problem hiding this comment.
I agree. It's much better than causing loads of unnecessary recompilations.
gaborigloi
left a comment
gaborigloi
left a comment
There was a problem hiding this comment.
Looks good, but I think there some more leftover from OASIS that should be removed.
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
3 participants
We were 2 releases behind with respect to @djs55 repository.
I think we should consider stopping having to independent forks and move everything into one place only (ping @djs55 @jonludlam).