CP-28365: improve backtraces by using finally #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
`Backtrace.is_important` was not called. We have a `finally` function that does the proper thing wrt to backtraces, use it. xapi-stdext-pervasives is a dependency of xapi-stdext-threads already, so this does not introduce a new dependency. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
We've got a `with_file` in this same file, use it instead of reimplementing it, so we get the improved backtraces. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
We cannot use finally here, because the socket is only closed on failure. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
mseri
approved these changes
May 30, 2018
Collaborator
|
I just noticed that there is a typo in the commits, sorry. |
mseri
reviewed
May 30, 2018
|
|
||
| (** daemonize a process *) | ||
| (* !! Must call this before spawning any threads !! *) | ||
| let daemonize () = |
Collaborator
There was a problem hiding this comment.
We should really deprecate this function... nowadays it's systemd duty to damonize
Contributor
Author
There was a problem hiding this comment.
Opened a ticket, CP-28369
mseri
reviewed
May 30, 2018
| (fun () -> Unix.close fd) | ||
|
|
||
| (** open a file, and make sure the close is always done *) | ||
| let with_file file mode perms f = |
Collaborator
There was a problem hiding this comment.
You could even expose this in the interface
Contributor
Author
There was a problem hiding this comment.
It already is, I just moved it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacktraces were lost in functions wrapped with
Mutex.execute:The
Pervasiveext.finallyfunction already does the right thing and callsBacktrace.is_important exnto not loose the stacktrace, so update all the handcoded finally functions to use our own finally.