CA-177513: Push RRDs to slaves correctly #2339
Merged
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since change eae565f, starting a VM on a slave host has caused a 'Pool_role.This_host_is_a_master' exception to be raised in Rrdd_proxy.push_rrd. The VM will start correctly, but no RRDs will be available. The exception is only raised when starting a VM on a slave. In this case, Rrdd_proxy.push_rrd incorrectly calls Pool_role.get_master_address, which raises an exception when run on the master. Rrdd_proxy.push_rrd is only ever run on the master, so the exception is always raised when starting a VM on the slave. Signed-off-by: Euan Harris <euan.harris@citrix.com>
Contributor
|
I think this looks good once we've done a dev-test. |
Contributor
Author
|
Dev test is somewhat positive. This seems to prevent the exception which was being raised when the VM was started on the slave, but it seems that there is a further problem with copying the RRD data back to the master on shutdown. If I start the VM on the slave, stop it and then start it again on the master, the performance graphs don't show any data from the time it was running on the slave. |
euanh
added a commit
that referenced
this pull request
Aug 14, 2015
CA-177513: Push RRDs to slaves correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since change eae565f, starting a VM on a slave host has caused
a 'Pool_role.This_host_is_a_master' exception to be raised in
Rrdd_proxy.push_rrd. The VM will start correctly, but no RRDs will
be available.
The exception is only raised when starting a VM on a slave. In this case,
Rrdd_proxy.push_rrd incorrectly calls Pool_role.get_master_address, which
raises an exception when run on the master. Rrdd_proxy.push_rrd is only
ever run on the master, so the exception is always raised when starting
a VM on the slave.
Signed-off-by: Euan Harris euan.harris@citrix.com