CA-289735: do not disable clustering daemon on shutdown from xapi-domains #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minishrink
approved these changes
Jun 1, 2018
edwintorok
force-pushed
the
feature/REQ477/master
branch
from
73c7cf5 to
df206fb
Compare
edwintorok
force-pushed
the
feature/REQ477/CA-289735
branch
from
b437172 to
9eae3c0
Compare
…ains Just unplug the PBDs, and allow the clustering daemon to shut itself down using the `xapi-clusterd-shutdown.service` unit. This is to avoid a circular dependency between `xapi-domains`, `dlm`, and `remote-fs` that prevents `dlm` from getting stopped from inside `xapi-domains` on shutdown. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
edwintorok
force-pushed
the
feature/REQ477/CA-289735
branch
from
9eae3c0 to
8054951
Compare
edwintorok
force-pushed
the
feature/REQ477/CA-289735
branch
from
8054951 to
2f0e5c2
Compare
gaborigloi
approved these changes
Jul 6, 2018
|
This can be merged together with the xenserver-specs and clustering daemon change. Wait until they're all approved and then merge. |
lindig
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just unplug the PBDs, and allow the clustering daemon to shut itself
down using the
xapi-clusterd-shutdown.serviceunit.This is to avoid a circular dependency between
xapi-domains,dlm,and
remote-fsthat preventsdlmfrom getting stopped from insidexapi-domainson shutdown.This needs to be merged together with matching PR on the clustering daemon.