Drop xen-gnt-unix dependency #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
force-pushed
the
private/edvint/xen-gnt
branch
from
b01a9df to
a62e8f9
Compare
|
🧹 |
The interdomain RRD implementation is not used by guests, and was just prototype code. This is last dependency between xs-opam and Xen, so remove it for now. We can reinstate it if/when we want to reintroduce a guest stats interface. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Only the native versions are installed and used. Although bytecode is quicker to build, building both just increases compilation time unnecessarily. A quick 'syntax-only' check can be done with 'dune build @check' if needed. (note that if native compilation is unavailable then 'exe' maps to bytecode still) This fixes various 'module Buf_io is unavailable' errors when running 'dune build'. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/xen-gnt
branch
from
a62e8f9 to
7ad1624
Compare
psafont
approved these changes
May 30, 2023
lindig
approved these changes
May 30, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested that a 'dune build', 'dune build @check' and 'dune runtest' pass locally.
Haven't yet tested on Koji (might need tweaking the specfile to drop some files).