-
Notifications
You must be signed in to change notification settings - Fork 292
CP-43131: Make gvt-g support configurable #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So long, old friend 👋 |
So long, old friend 😄 |
@johnelse is still around and watching PRs here!! |
Lots of us are still watching! 👀 |
Oh dear... we'd better be more careful about what we are saying here... 😬 |
8cca2a1
to
e16c21b
Compare
I rebase to one single commit as the |
e16c21b
to
ff21643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the checks in start/resume/resume_on are redundant and would be covered by the 'allocate_vm_to_host' check.
What happens to the PGPUs though, will XAPI do the right thing on startup and remove the gvt-g ones if not supported due to the change in the 'find_or_create_supported'?
With current early check and block,
I would like to argue just keep it (yes, we can handle the exception and re-raise at proper place, but that sounds more complicated.)
|
f1151f8
to
6e7cf11
Compare
|
Introduce config gvt-g-supported and default to true If set to false, then gvt-g vGPU is taken as on longer supported, thus block VM start/resume/migrate operation for VM with such vGPU The gvt-g related code are kept for compatiblility with xs8, and will be dropped at proper time Signed-off-by: Lin Liu <lin.liu@citrix.com>
6e7cf11
to
7027ef0
Compare
This PR will not be merged until xs9 is ready,
Please just help to review this PR and approve if you are happy, we will merge it later.
Edit: This PR is updated to make gvt-g support configurable, so it can be merged to master as early as possible,
The legacy code can be removed later at proper time.