CA-418759: Failed to start attach-static-vdis #6722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlei-li
reviewed
Oct 23, 2025
ocaml/xapi/static_vdis.ml
Outdated
| try ignore (Helpers.call_script "/sbin/service" [script; "start"]) | ||
| debug "%s: Attempt to reattach static VDIs" __FUNCTION__ ; | ||
| let service = "attach-static-vdis.service" in | ||
| try ignore (Xapi_systemctl.start ~wait_until_success:false service) |
There was a problem hiding this comment.
return type of Xapi_systemctl.start is unit. No need to use ignore.
changlei-li
approved these changes
Oct 23, 2025
lindig
approved these changes
Oct 23, 2025
Xapi still uses `/sbin/service` to start `attach-static-vdis` when boots up for HA. It will fail in XS 9 as `/sbin/service` has been removed in XS 9. Replace it with `systemctl`. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
BengangY
force-pushed
the
private/bengangy/CA-418759
branch
from
8b48885 to
bcc7709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xapi still uses
/sbin/serviceto startattach-static-vdiswhen boots up for HA. It will fail in XS 9 as/sbin/servicehas been removed in XS 9.Replace it with
systemctl.