Skip to content

Conversation

@Freso
Copy link
Contributor

@Freso Freso commented Apr 9, 2019

Description

The current/old PR template asks for commits to use “vX.Y.Z” in commits adding add‐ons to the repository, but in actuality the vast majority of commits use “X.Y.Z” without the “v”[1]. This is just a small change to make the template reflect actual usage.

[1]
https://github.com/xbmc/repo-scripts/commits/leia
https://github.com/xbmc/repo-scripts/commits/krypton
etc.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

The current/old PR template asks for commits to use “vX.Y.Z” in commits
adding add‐ons to the repository, but in actuality the vast majority of
commits use “X.Y.Z” without the “v”[1]. This is just a small change to make
the template reflect actual usage.

[1]
   https://github.com/xbmc/repo-scripts/commits/leia
   https://github.com/xbmc/repo-scripts/commits/krypton
   etc.
@Freso
Copy link
Contributor Author

Freso commented Apr 9, 2019

This is also the format recommended/prescribed on the wiki:
https://kodi.wiki/view/Submitting_Add-ons#Pull_requests

@razzeee
Copy link
Member

razzeee commented May 13, 2019

Thank you

@razzeee razzeee merged commit 162e807 into xbmc:master May 13, 2019
@Freso Freso deleted the update-pr-template branch May 13, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants