feat: implement longest prefix matching for pathMappings (closes #331) #363
Conversation
|
Hm, the Travis builds fail to install Xdebug. @felixfbecker Do you have any idea why? |
…ug#331) cherry-picked from xdebug#363
|
Activating this. Shall we take a look if this could be implemented ? this case scenario is quite common for WordPress development often wp-content is on its own and the WordPress folder maps differently. |
|
Hi @bjoluc . Can you rebase this onto main? I'll have a fresh look at it then. |
|
Sure, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 66.72% 66.72%
=======================================
Files 6 6
Lines 1070 1070
Branches 168 170 +2
=======================================
Hits 714 714
Misses 356 356
Continue to review full report at Codecov.
|
Based on the test cases over at robberphex/vscode-php-debug@729be1d. Thanks @robberphex!
|
Looks great. I'll to another round of tests here and merge it then. Thanks! |
…#363) * fix: implement longest prefix matching for pathMappings (closes #331) * test: add test cases for server path longest prefix matching Based on the test cases over at robberphex/vscode-php-debug@729be1d. Thanks @robberphex!
…#363) * fix: implement longest prefix matching for pathMappings (closes #331) * test: add test cases for server path longest prefix matching Based on the test cases over at robberphex/vscode-php-debug@729be1d. Thanks @robberphex!
4 participants
I decided to approach #331 and it turned out to be only a minor change. I also added longest prefix matching for the client to debugger mapping as there are use cases for this as well and it does not affect the existing mapping behavior (unless in actual use cases in which the change is most certainly welcome).