Embedding libxdp #26
Merged
Embedding libxdp #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds libxdp as a submodule and link target alongside libbpf. This should make it just as easy for examples to use libxdp as it currently is for libbpf. Some hoops need to be jumped through to make libxdp link against the same version of libbpf as the one we use in this repository. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Instead of having the someone redundantly named 'lib/lib-install' folder, let's rename it to just 'lib/install', and drop the 'usr/' prefix of the files installed into that directory. Also, to simplify the configure script, check in the directory to git so it's always present, and always include it in the include and linker paths. On clean we just clear out the contents. Also, copy over libbpf.a to lib/install/lib alongside libxdp.a instead of putting libbpf/src in the linker path. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Pull the latest version of xdp-tools into the submodule. Change the wildcard pattern for libxdp to not include the XDP programs to avoid constantly recompiling it. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Include logging.{h,c} from xdp-tools so utilities can use them for setting
libxdp and libbpf logging.
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Use the newly-added logging helpers from logging.h and add a -v option to increase the effective log level. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for embedding libxdp and linking userspace binaries against it. It relies on recent changes in the xdp-tools repository to support this.
There's one outstanding issue with this: the embedded version of libxdp needs to be able to find the dispatcher BPF object, which it is not able to do with the custom install path currently. This needs to be fixed in upstream libxdp.