Skip to content

Commit cb376be

Browse files
Bug 920377 part.28 Get rid of nsDragEvent r=roc
1 parent 73191e0 commit cb376be

File tree

19 files changed

+47
-47
lines changed

19 files changed

+47
-47
lines changed

content/base/public/nsContentUtils.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,9 +1407,9 @@ class nsContentUtils
14071407
static already_AddRefed<nsIDragSession> GetDragSession();
14081408

14091409
/*
1410-
* Initialize and set the dataTransfer field of an nsDragEvent.
1410+
* Initialize and set the dataTransfer field of an WidgetDragEvent.
14111411
*/
1412-
static nsresult SetDataTransferInEvent(nsDragEvent* aDragEvent);
1412+
static nsresult SetDataTransferInEvent(mozilla::WidgetDragEvent* aDragEvent);
14131413

14141414
// filters the drag and drop action to fit within the effects allowed and
14151415
// returns it.
@@ -1420,7 +1420,7 @@ class nsContentUtils
14201420
* an ancestor of the document for the source of the drag.
14211421
*/
14221422
static bool CheckForSubFrameDrop(nsIDragSession* aDragSession,
1423-
nsDragEvent* aDropEvent);
1423+
mozilla::WidgetDragEvent* aDropEvent);
14241424

14251425
/**
14261426
* Return true if aURI is a local file URI (i.e. file://).

content/base/src/nsContentUtils.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4979,7 +4979,7 @@ nsContentUtils::GetDragSession()
49794979

49804980
/* static */
49814981
nsresult
4982-
nsContentUtils::SetDataTransferInEvent(nsDragEvent* aDragEvent)
4982+
nsContentUtils::SetDataTransferInEvent(WidgetDragEvent* aDragEvent)
49834983
{
49844984
if (aDragEvent->dataTransfer || !aDragEvent->mFlags.mIsTrusted)
49854985
return NS_OK;
@@ -5081,7 +5081,8 @@ nsContentUtils::FilterDropEffect(uint32_t aAction, uint32_t aEffectAllowed)
50815081

50825082
/* static */
50835083
bool
5084-
nsContentUtils::CheckForSubFrameDrop(nsIDragSession* aDragSession, nsDragEvent* aDropEvent)
5084+
nsContentUtils::CheckForSubFrameDrop(nsIDragSession* aDragSession,
5085+
WidgetDragEvent* aDropEvent)
50855086
{
50865087
nsCOMPtr<nsIContent> target = do_QueryInterface(aDropEvent->originalTarget);
50875088
if (!target) {

content/events/src/nsDOMDragEvent.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ nsDOMDragEvent::nsDOMDragEvent(mozilla::dom::EventTarget* aOwner,
1515
nsPresContext* aPresContext,
1616
WidgetInputEvent* aEvent)
1717
: nsDOMMouseEvent(aOwner, aPresContext, aEvent ? aEvent :
18-
new nsDragEvent(false, 0, nullptr))
18+
new WidgetDragEvent(false, 0, nullptr))
1919
{
2020
if (aEvent) {
2121
mEventIsInternal = false;
@@ -32,7 +32,7 @@ nsDOMDragEvent::~nsDOMDragEvent()
3232
{
3333
if (mEventIsInternal) {
3434
if (mEvent->eventStructType == NS_DRAG_EVENT)
35-
delete static_cast<nsDragEvent*>(mEvent);
35+
delete static_cast<WidgetDragEvent*>(mEvent);
3636
mEvent = nullptr;
3737
}
3838
}
@@ -62,7 +62,7 @@ nsDOMDragEvent::InitDragEvent(const nsAString & aType,
6262
NS_ENSURE_SUCCESS(rv, rv);
6363

6464
if (mEventIsInternal && mEvent) {
65-
nsDragEvent* dragEvent = static_cast<nsDragEvent*>(mEvent);
65+
WidgetDragEvent* dragEvent = static_cast<WidgetDragEvent*>(mEvent);
6666
dragEvent->dataTransfer = aDataTransfer;
6767
}
6868

@@ -88,7 +88,7 @@ nsDOMDragEvent::GetDataTransfer()
8888
return nullptr;
8989
}
9090

91-
nsDragEvent* dragEvent = static_cast<nsDragEvent*>(mEvent);
91+
WidgetDragEvent* dragEvent = static_cast<WidgetDragEvent*>(mEvent);
9292
// for synthetic events, just use the supplied data transfer object even if null
9393
if (!mEventIsInternal) {
9494
nsresult rv = nsContentUtils::SetDataTransferInEvent(dragEvent);
@@ -101,7 +101,7 @@ nsDOMDragEvent::GetDataTransfer()
101101
nsresult NS_NewDOMDragEvent(nsIDOMEvent** aInstancePtrResult,
102102
mozilla::dom::EventTarget* aOwner,
103103
nsPresContext* aPresContext,
104-
nsDragEvent *aEvent)
104+
WidgetDragEvent* aEvent)
105105
{
106106
nsDOMDragEvent* event = new nsDOMDragEvent(aOwner, aPresContext, aEvent);
107107
return CallQueryInterface(event, aInstancePtrResult);

content/events/src/nsDOMDragEvent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ class nsDOMDragEvent : public nsDOMMouseEvent,
5555
nsresult NS_NewDOMDragEvent(nsIDOMEvent** aInstancePtrResult,
5656
mozilla::dom::EventTarget* aOwner,
5757
nsPresContext* aPresContext,
58-
nsDragEvent* aEvent);
58+
mozilla::WidgetDragEvent* aEvent);
5959

6060
#endif // nsDOMDragEvent_h__

content/events/src/nsDOMEvent.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsDOMEvent)
147147
nullptr;
148148
break;
149149
case NS_DRAG_EVENT:
150-
static_cast<nsDragEvent*>(tmp->mEvent)->dataTransfer = nullptr;
150+
static_cast<WidgetDragEvent*>(tmp->mEvent)->dataTransfer = nullptr;
151151
static_cast<WidgetMouseEventBase*>(tmp->mEvent)->relatedTarget =
152152
nullptr;
153153
break;
@@ -189,7 +189,7 @@ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(nsDOMEvent)
189189
case NS_DRAG_EVENT:
190190
NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(cb, "mEvent->dataTransfer");
191191
cb.NoteXPCOMChild(
192-
static_cast<nsDragEvent*>(tmp->mEvent)->dataTransfer);
192+
static_cast<WidgetDragEvent*>(tmp->mEvent)->dataTransfer);
193193
NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(cb, "mEvent->relatedTarget");
194194
cb.NoteXPCOMChild(
195195
static_cast<WidgetMouseEventBase*>(tmp->mEvent)->relatedTarget);
@@ -559,9 +559,8 @@ nsDOMEvent::DuplicatePrivateData()
559559
}
560560
case NS_DRAG_EVENT:
561561
{
562-
nsDragEvent* oldDragEvent = static_cast<nsDragEvent*>(mEvent);
563-
nsDragEvent* dragEvent =
564-
new nsDragEvent(false, msg, nullptr);
562+
WidgetDragEvent* oldDragEvent = static_cast<WidgetDragEvent*>(mEvent);
563+
WidgetDragEvent* dragEvent = new WidgetDragEvent(false, msg, nullptr);
565564
dragEvent->AssignDragEventData(*oldDragEvent, true);
566565
newEvent = dragEvent;
567566
break;

content/events/src/nsEventDispatcher.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ nsEventDispatcher::CreateEvent(mozilla::dom::EventTarget* aOwner,
722722
static_cast<WheelEvent*>(aEvent));
723723
case NS_DRAG_EVENT:
724724
return NS_NewDOMDragEvent(aDOMEvent, aOwner, aPresContext,
725-
static_cast<nsDragEvent*>(aEvent));
725+
static_cast<WidgetDragEvent*>(aEvent));
726726
case NS_TEXT_EVENT:
727727
return NS_NewDOMTextEvent(aDOMEvent, aOwner, aPresContext,
728728
static_cast<WidgetTextEvent*>(aEvent));

content/events/src/nsEventStateManager.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1928,12 +1928,12 @@ nsEventStateManager::GenerateDragGesture(nsPresContext* aPresContext,
19281928
nsCOMPtr<nsIWidget> widget = mCurrentTarget->GetNearestWidget();
19291929

19301930
// get the widget from the target frame
1931-
nsDragEvent startEvent(aEvent->mFlags.mIsTrusted,
1932-
NS_DRAGDROP_START, widget);
1931+
WidgetDragEvent startEvent(aEvent->mFlags.mIsTrusted,
1932+
NS_DRAGDROP_START, widget);
19331933
FillInEventFromGestureDown(&startEvent);
19341934

1935-
nsDragEvent gestureEvent(aEvent->mFlags.mIsTrusted,
1936-
NS_DRAGDROP_GESTURE, widget);
1935+
WidgetDragEvent gestureEvent(aEvent->mFlags.mIsTrusted,
1936+
NS_DRAGDROP_GESTURE, widget);
19371937
FillInEventFromGestureDown(&gestureEvent);
19381938

19391939
startEvent.dataTransfer = gestureEvent.dataTransfer = dataTransfer;
@@ -1961,7 +1961,7 @@ nsEventStateManager::GenerateDragGesture(nsPresContext* aPresContext,
19611961
nsEventDispatcher::Dispatch(targetContent, aPresContext, &startEvent, nullptr,
19621962
&status);
19631963

1964-
nsDragEvent* event = &startEvent;
1964+
WidgetDragEvent* event = &startEvent;
19651965
if (status != nsEventStatus_eConsumeNoDefault) {
19661966
status = nsEventStatus_eIgnore;
19671967
nsEventDispatcher::Dispatch(targetContent, aPresContext, &gestureEvent, nullptr,
@@ -2086,7 +2086,7 @@ nsEventStateManager::DetermineDragTarget(nsPresContext* aPresContext,
20862086

20872087
bool
20882088
nsEventStateManager::DoDefaultDragStart(nsPresContext* aPresContext,
2089-
nsDragEvent* aDragEvent,
2089+
WidgetDragEvent* aDragEvent,
20902090
nsDOMDataTransfer* aDataTransfer,
20912091
nsIContent* aDragTarget,
20922092
nsISelection* aSelection)
@@ -3253,7 +3253,7 @@ nsEventStateManager::PostHandleEvent(nsPresContext* aPresContext,
32533253
nsCOMPtr<nsIDOMDataTransfer> initialDataTransfer;
32543254
dragSession->GetDataTransfer(getter_AddRefs(initialDataTransfer));
32553255

3256-
nsDragEvent *dragEvent = (nsDragEvent*)aEvent;
3256+
WidgetDragEvent *dragEvent = static_cast<WidgetDragEvent*>(aEvent);
32573257

32583258
// collect any changes to moz cursor settings stored in the event's
32593259
// data transfer.
@@ -3348,8 +3348,8 @@ nsEventStateManager::PostHandleEvent(nsPresContext* aPresContext,
33483348
getter_AddRefs(targetContent));
33493349

33503350
nsCOMPtr<nsIWidget> widget = mCurrentTarget->GetNearestWidget();
3351-
nsDragEvent event(aEvent->mFlags.mIsTrusted,
3352-
NS_DRAGDROP_DRAGDROP, widget);
3351+
WidgetDragEvent event(aEvent->mFlags.mIsTrusted,
3352+
NS_DRAGDROP_DRAGDROP, widget);
33533353

33543354
nsMouseEvent* mouseEvent = static_cast<nsMouseEvent*>(aEvent);
33553355
event.refPoint = mouseEvent->refPoint;
@@ -4275,7 +4275,7 @@ nsEventStateManager::FireDragEnterOrExit(nsPresContext* aPresContext,
42754275
nsWeakFrame& aTargetFrame)
42764276
{
42774277
nsEventStatus status = nsEventStatus_eIgnore;
4278-
nsDragEvent event(aEvent->mFlags.mIsTrusted, aMsg, aEvent->widget);
4278+
WidgetDragEvent event(aEvent->mFlags.mIsTrusted, aMsg, aEvent->widget);
42794279
event.refPoint = aEvent->refPoint;
42804280
event.modifiers = ((nsMouseEvent*)aEvent)->modifiers;
42814281
event.buttons = ((nsMouseEvent*)aEvent)->buttons;
@@ -4308,7 +4308,7 @@ nsEventStateManager::FireDragEnterOrExit(nsPresContext* aPresContext,
43084308
}
43094309

43104310
void
4311-
nsEventStateManager::UpdateDragDataTransfer(nsDragEvent* dragEvent)
4311+
nsEventStateManager::UpdateDragDataTransfer(WidgetDragEvent* dragEvent)
43124312
{
43134313
NS_ASSERTION(dragEvent, "drag event is null in UpdateDragDataTransfer!");
43144314
if (!dragEvent->dataTransfer)

content/events/src/nsEventStateManager.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ class nsEventStateManager : public nsSupportsWeakReference,
292292
* Update the initial drag session data transfer with any changes that occur
293293
* on cloned data transfer objects used for events.
294294
*/
295-
void UpdateDragDataTransfer(nsDragEvent* dragEvent);
295+
void UpdateDragDataTransfer(mozilla::WidgetDragEvent* dragEvent);
296296

297297
nsresult SetClickCount(nsPresContext* aPresContext, nsMouseEvent *aEvent, nsEventStatus* aStatus);
298298
nsresult CheckForAndDispatchClick(nsPresContext* aPresContext, nsMouseEvent *aEvent, nsEventStatus* aStatus);
@@ -691,10 +691,10 @@ class nsEventStateManager : public nsSupportsWeakReference,
691691
* aSelection - the selection to be dragged
692692
*/
693693
bool DoDefaultDragStart(nsPresContext* aPresContext,
694-
nsDragEvent* aDragEvent,
695-
nsDOMDataTransfer* aDataTransfer,
696-
nsIContent* aDragTarget,
697-
nsISelection* aSelection);
694+
mozilla::WidgetDragEvent* aDragEvent,
695+
nsDOMDataTransfer* aDataTransfer,
696+
nsIContent* aDragTarget,
697+
nsISelection* aSelection);
698698

699699
bool IsTrackingDragGesture ( ) const { return mGestureDownContent != nullptr; }
700700
/**

dom/interfaces/events/nsIDOMEvent.idl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ nsresult
262262
NS_NewDOMDragEvent(nsIDOMEvent** aInstancePtrResult,
263263
mozilla::dom::EventTarget* aOwner,
264264
nsPresContext* aPresContext,
265-
nsDragEvent* aEvent);
265+
mozilla::WidgetDragEvent* aEvent);
266266
nsresult
267267
NS_NewDOMClipboardEvent(nsIDOMEvent** aInstancePtrResult,
268268
mozilla::dom::EventTarget* aOwner,

editor/libeditor/text/nsPlaintextDataTransfer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ nsresult nsPlaintextEditor::InsertFromDrop(nsIDOMEvent* aDropEvent)
182182
NS_ENSURE_TRUE(sourceNode, NS_ERROR_FAILURE);
183183
}
184184

185-
nsDragEvent* dragEventInternal = static_cast<nsDragEvent *>(aDropEvent->GetInternalNSEvent());
185+
WidgetDragEvent* dragEventInternal =
186+
static_cast<WidgetDragEvent*>(aDropEvent->GetInternalNSEvent());
186187
if (nsContentUtils::CheckForSubFrameDrop(dragSession, dragEventInternal)) {
187188
// Don't allow drags from subframe documents with different origins than
188189
// the drop destination.

0 commit comments

Comments
 (0)