Bug 847521 - Allow CheckedInt<signed char> in addition to char/unsigned char. char != signed char (but is guaranteed to have the same representation as either signed char or unsigned char, for backwards-compatibility reasons), so we have to handle signed char as a third character type. r=bjacob

--HG--
rename : content/html/content/src/HTMLObjectElement.h => content/html/content/src/HTMLObjectElement.cpp
extra : rebase_source : d07d72b78fcbae31483d726703b3605561295684

Author: jswalden

mfbt/CheckedInt.h

@@ -104,6 +104,10 @@ template<>
 struct IsSupportedPass2<char>
 { static const bool value = true; };
 
+template<>
+struct IsSupportedPass2<signed char>
+{ static const bool value = true; };
+
 template<>
 struct IsSupportedPass2<unsigned char>
 { static const bool value = true; };

mfbt/tests/TestCheckedInt.cpp

@@ -413,12 +413,14 @@ void test()
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(int64_t)
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(uint64_t)
 
+  typedef signed char signedChar;
   typedef unsigned char unsignedChar;
   typedef unsigned short unsignedShort;
   typedef unsigned int  unsignedInt;
   typedef unsigned long unsignedLong;
 
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(char)
+  VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(signedChar)
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(unsignedChar)
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(short)
   VERIFY_CONSTRUCTION_FROM_INTEGER_TYPE(unsignedShort)
@@ -470,6 +472,7 @@ int main()
   test<uint64_t>();
 
   test<char>();
+  test<signed char>();
   test<unsigned char>();
   test<short>();
   test<unsigned short>();
@@ -478,9 +481,11 @@ int main()
   test<long>();
   test<unsigned long>();
 
-  if (gIntegerTypesTested < 8) {
+  const int MIN_TYPES_TESTED = 9;
+  if (gIntegerTypesTested < MIN_TYPES_TESTED) {
     std::cerr << "Only " << gIntegerTypesTested << " have been tested. "
-              << "This should not be less than 8." << std::endl;
+              << "This should not be less than " << MIN_TYPES_TESTED << "."
+              << std::endl;
     gTestsFailed++;
   }