Skip to content

fix: text primitive tech debt #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: text primitive tech debt #959

merged 1 commit into from
Jan 30, 2023

Conversation

@jpvsalvador
Copy link
Contributor

@jpvsalvador jpvsalvador commented Jan 30, 2023

Relates to #956
Fixes #956

Proposed Changes

  • New Text primitive variant "visible"
  • Delete unused files

This pull request closes #956

@jpvsalvador jpvsalvador added bug Something isn't working frontend labels Jan 30, 2023
@jpvsalvador jpvsalvador requested review from a team and StereoPT January 30, 2023 11:10
@jpvsalvador jpvsalvador linked an issue Jan 30, 2023 that may be closed by this pull request
[BUG]: fix: text primitive tech debt #956
Closed
@jpvsalvador jpvsalvador self-assigned this Jan 30, 2023
StereoPT
StereoPT approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗝️

@jpvsalvador jpvsalvador merged commit c6e7eef into main Jan 30, 2023
@jpvsalvador jpvsalvador deleted the 956-bug-fix-text-primitive-tech-debt branch January 30, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StereoPT StereoPT StereoPT approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels

bug Something isn't working frontend

Projects

SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: fix: text primitive tech debt

3 participants

@jpvsalvador @StereoPT