Replies: 1 comment
-
|
You're right. The reason Command and CommandDispatch are generic is because I copied the code from xit, which actually needs them to be generic. I will fix it. Yeah I probably don't need to pass repo_kind at all in haxy since the server-side repos will always be in the xit format. I will probably keep it there for now though, so it is easy to run experiments where I store repos in the git repo format. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
While I red repo, I had question in my mind: For what reason
are passed everywhere.
CommandandCommandDispatchare generic around them, if they do not use those parameters at all? (I deleted it, making plain struct/union and everything continued working.).xitand.gitrepo (storage?) kinds at the same time? If no, why you wouldn't store them as global constants for example inconfiguration.ziglike that:and access on demand, not passing them from main function?
I'm not saying it is wrong, but just can't wrap my head around.
Beta Was this translation helpful? Give feedback.
All reactions