Skip to content

Commit 0f5e7f1

Browse files
committed
fix(lore): proper implementation for page support in lore search
1 parent 6f90c2b commit 0f5e7f1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/xivapi.service.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,14 @@ export class XivapiService {
4747
* @param lang
4848
* @param allLanguages should it include Text_*?
4949
* @param dataColumns Additional data you want to fetch.
50+
* @param page data page to get
5051
*/
5152
public searchLore(query: string, lang: string = 'en', allLanguages: boolean = false,
52-
dataColumns: string[] = []): Observable<LoreSearchResult> {
53+
dataColumns: string[] = [], page: number = 1): Observable<LoreSearchResult> {
5354
let httpParams: HttpParams = new HttpParams()
5455
.set('string', query)
55-
.set('language', lang);
56+
.set('language', lang)
57+
.set('page', page.toString());
5658
if (dataColumns && dataColumns.length > 0) {
5759
const columns: string[] = [
5860
'Context',
@@ -283,8 +285,8 @@ export class XivapiService {
283285
* @param options Options of the request.
284286
*/
285287
public getMarketBoardItemsForServers(servers: string[],
286-
itemIds: number[],
287-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem[] }[]> {
288+
itemIds: number[],
289+
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem[] }[]> {
288290
options.servers = servers;
289291
options.extraQueryParams = options.extraQueryParams || {};
290292
options.extraQueryParams['ids'] = itemIds.join(',');
@@ -299,7 +301,7 @@ export class XivapiService {
299301
* @param options Options of the request.
300302
*/
301303
public getMarketBoardItemsCrossServer(datacenter: string, itemIds: number[],
302-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem }[]> {
304+
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem }[]> {
303305
options.extraQueryParams = options.extraQueryParams || {};
304306
options.extraQueryParams['dc'] = datacenter;
305307
options.extraQueryParams['ids'] = itemIds.join(',');

0 commit comments

Comments
 (0)