Skip to content

Commit 88a1c4e

Browse files
committed
fix: support for string type in lodestoneIds for long ids (Free company mainly)
1 parent e8b5149 commit 88a1c4e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/xivapi.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class XivapiService {
7474
* @param options Options of the request.
7575
* @param details Specific details you want to get.
7676
*/
77-
public getCharacter(lodestoneId: number, options?: XivapiCharacterOptions,
77+
public getCharacter(lodestoneId: number | string, options?: XivapiCharacterOptions,
7878
details?: 'Friends' | 'Achievements' | 'Gearsets' | 'Record' | 'FreeCompany'): Observable<CharacterResponse> {
7979
return this.request<any>(`/Character/${lodestoneId}${details ? '/' + details : ''}`, options);
8080
}
@@ -127,7 +127,7 @@ export class XivapiService {
127127
* @param options Options of the request.
128128
* @param details Specific details you want to get.
129129
*/
130-
public getFreeCompany(lodestoneId: number, options?: XivapiOptions,
130+
public getFreeCompany(lodestoneId: number | string, options?: XivapiOptions,
131131
details?: 'members' | 'record'): Observable<any> {
132132
return this.request<any>(`/FreeCompany/${lodestoneId}${details ? '/' + details : ''}`, options);
133133
}
@@ -139,7 +139,7 @@ export class XivapiService {
139139
* @param options Options of the request.
140140
* @param details Specific details you want to get.
141141
*/
142-
public getLinkshell(lodestoneId: number, options?: XivapiOptions,
142+
public getLinkshell(lodestoneId: number | string, options?: XivapiOptions,
143143
details?: 'record'): Observable<any> {
144144
return this.request<any>(`/Linkshell/${lodestoneId}${details ? '/' + details : ''}`, options);
145145
}

0 commit comments

Comments
 (0)