Skip to content

Commit bd39473

Browse files
latenightwreckSupamiu
authored andcommitted
refactor(market): remove all instances of marketboard requests
BREAKING CHANGES: Marketboard API isn't available anymore.
1 parent e8f6a5d commit bd39473

File tree

6 files changed

+31
-143
lines changed

6 files changed

+31
-143
lines changed

package-lock.json

Lines changed: 30 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/model/schema/market/marketboard-history.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/model/schema/market/marketboard-item-history.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/model/schema/market/marketboard-item.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/model/schema/market/marketboard-price.ts

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/xivapi.service.ts

Lines changed: 1 addition & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
XivapiSearchOptions
1414
} from './model';
1515
import { CharacterResponse, CharacterVerification } from './model/schema/character';
16-
import { MarketboardItem } from './model/schema/market/marketboard-item';
1716
import { GCF_URL } from './xivapi-client.module';
1817
import { LoreSearchResult } from './model/lore-search-result';
1918

@@ -238,77 +237,7 @@ export class XivapiService {
238237
return this.request<any>(`/PatchList`, options);
239238
}
240239

241-
/**
242-
* Gets marketboard informations for a given item.
243-
*
244-
* @param server The server to use for marketboard informations.
245-
* @param itemId The item you want informations on.
246-
* @param options Options of the request.
247-
*/
248-
public getMarketBoardItem(server: string, itemId: number, options?: XivapiOptions): Observable<MarketboardItem> {
249-
return this.request<MarketboardItem>(`/market/${server}/item/${itemId}`, options);
250-
}
251-
252-
/**
253-
* Gets marketboard informations for a given item on multiple servers.
254-
*
255-
* @param servers
256-
* @param itemId The item you want informations on.
257-
* @param options Options of the request.
258-
*/
259-
public getMarketBoardItemForServers(servers: string[],
260-
itemId: number,
261-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem[] }> {
262-
options.servers = servers;
263-
return this.request<{ [index: string]: MarketboardItem[] }>(`/market/item/${itemId}`, options);
264-
}
265-
266-
/**
267-
* Gets marketboard informations for a given item.
268-
*
269-
* @param datacenter The datacenter to use for marketboard informations.
270-
* @param itemId The item you want informations on.
271-
* @param options Options of the request.
272-
*/
273-
public getMarketBoardItemCrossServer(datacenter: string, itemId: number,
274-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem }> {
275-
options.extraQueryParams = options.extraQueryParams || {};
276-
options.extraQueryParams['dc'] = datacenter;
277-
return this.request<{ [index: string]: MarketboardItem }>(`/market/item/${itemId}`, options);
278-
}
279-
280-
/**
281-
* Gets marketboard informations for a given item on multiple servers.
282-
*
283-
* @param servers
284-
* @param itemIds The items you want informations on.
285-
* @param options Options of the request.
286-
*/
287-
public getMarketBoardItemsForServers(servers: string[],
288-
itemIds: number[],
289-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem[] }[]> {
290-
options.servers = servers;
291-
options.extraQueryParams = options.extraQueryParams || {};
292-
options.extraQueryParams['ids'] = itemIds.join(',');
293-
return this.request<{ [index: string]: MarketboardItem[] }[]>(`/market/items`, options);
294-
}
295-
296-
/**
297-
* Gets marketboard informations for a given set of items.
298-
*
299-
* @param datacenter The datacenter to use for marketboard informations.
300-
* @param itemIds The items you want informations on.
301-
* @param options Options of the request.
302-
*/
303-
public getMarketBoardItemsCrossServer(datacenter: string, itemIds: number[],
304-
options: XivapiOptions = {}): Observable<{ [index: string]: MarketboardItem }[]> {
305-
options.extraQueryParams = options.extraQueryParams || {};
306-
options.extraQueryParams['dc'] = datacenter;
307-
options.extraQueryParams['ids'] = itemIds.join(',');
308-
return this.request<{ [index: string]: MarketboardItem }[]>(`/market/items`, options);
309-
}
310-
311-
protected request<T>(endpoint: string, params?: XivapiOptions): Observable<T> {
240+
protected request<T>(endpoint: string, params?: XivapiOptions): Observable<T> {
312241
let queryParams: HttpParams = this.prepareQueryString(params);
313242
let baseUrl: string;
314243
if (params !== undefined) {

0 commit comments

Comments
 (0)