Crash on net5. Maybe try fixing with VirtualProtect

[daemitus]

Set memory permissions before trying to modify non-write code. Might solve the crash in net5.
https://github.com/xivdev/Penumbra/blob/master/Penumbra/Hooks/SoundShit.cs#L26

Here's some code from my branch to do the dirty deed.

        public static MemoryProtection ChangePermission(IntPtr memoryAddress, int length, MemoryProtection newPermissions)
        {
            var result = VirtualProtect(memoryAddress, (UIntPtr)length, newPermissions, out var oldPermissions);

            if (!result)
                throw new Exception($"Unable to change permissions at 0x{memoryAddress.ToInt64():X} of length {length} and permission {newPermissions} (result={result})");

            var last = Marshal.GetLastWin32Error();
            if (last > 0)
                throw new Exception($"Unable to change permissions at 0x{memoryAddress.ToInt64():X} of length {length} and permission {newPermissions} (error={last})");

            return oldPermissions;
        }

        public static void ChangePermission(IntPtr memoryAddress, int length, MemoryProtection newPermissions, out MemoryProtection oldPermissions)
            => oldPermissions = ChangePermission(memoryAddress, length, newPermissions);

        [DllImport("kernel32.dll", SetLastError = true, ExactSpelling = true)]
        public static extern bool VirtualProtect(
            IntPtr lpAddress,
            UIntPtr dwSize,
            MemoryProtection flNewProtection,
            out MemoryProtection lpflOldProtect);

        [Flags]
        public enum MemoryProtection
        {
            Execute = 0x10,
            ExecuteRead = 0x20,
            ExecuteReadWrite = 0x40,
            ExecuteWriteCopy = 0x80,
            NoAccess = 0x01,
            ReadOnly = 0x02,
            ReadWrite = 0x04,
            WriteCopy = 0x08,
            TargetsInvalid = 0x40000000,
            TargetsNoUpdate = TargetsInvalid,
            Guard = 0x100,
            NoCache = 0x200,
            WriteCombine = 0x400,
        }

[daemitus]

If you build me a copy with this shiz in it, ill run it and let you know how it works

[NotAdam]

that doesn't modify anything that isn't writeable though - it just pulls the offset out so we can grab the ptr in framework to the sound manager which is on the heap in rw memory

[daemitus]

As always, you're right. I tracked it down to something else.