Skip to content

Conversation

@Shiffted
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 25, 2025

@Shiffted is attempting to deploy a commit to the waruqi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for mellow-creponne-9cce3d ready!

Name Link
🔨 Latest commit d301f50
🔍 Latest deploy log https://app.netlify.com/projects/mellow-creponne-9cce3d/deploys/68d54e692564070008767466
😎 Deploy Preview https://deploy-preview-238--mellow-creponne-9cce3d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Shiffted, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the accuracy and usability of the English documentation by correcting several internal links. Previously, these links incorrectly included a /zh prefix, directing users to Chinese localized pages instead of their English counterparts. The changes ensure that all referenced documentation pages are correctly accessible within the English context, streamlining navigation for users.

Highlights

  • Link Correction: Removed the /zh prefix from internal documentation links to ensure they correctly point to English content.
  • Documentation Consistency: Addressed inconsistencies where English documentation pages contained links intended for Chinese localized content, leading to potential navigation issues.
  • Improved Navigation: Enhanced user experience by fixing broken or misdirected links across several documentation files, making the English documentation more reliable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes several links in the English documentation that were pointing to Chinese versions. I've also found a couple of other minor issues in the changed lines, such as a redundant link text and an incorrect link, and have provided suggestions to fix them. Overall, good job on improving the documentation.

:::

For the configuration description of the package, see: [Package description description](/zh/guide/package-management/package-distribution).
For the configuration description of the package, see: [Package description description](/guide/package-management/package-distribution).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The link text "Package description description" is redundant. It should probably be "Package Distribution" to match the title of the linked page.

Suggested change
For the configuration description of the package, see: [Package description description](/guide/package-management/package-distribution).
For the configuration description of the package, see: [Package Distribution](/guide/package-management/package-distribution).

#### Integrate with other build systems

We also support the integration of code libraries maintained by other build systems such as Meson/Scons/Make. You only need to import the corresponding build auxiliary modules. I won’t go into details here. We can further check the documentation: [Integrate local third-party source code libraries ](/zh/guide/package-management/using-official-packages)
We also support the integration of code libraries maintained by other build systems such as Meson/Scons/Make. You only need to import the corresponding build auxiliary modules. I won’t go into details here. We can further check the documentation: [Integrate local third-party source code libraries ](/guide/package-management/using-official-packages)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are two issues here:

  1. The link text has a trailing space.
  2. The link points to /guide/package-management/using-official-packages, but the content about integrating local third-party source code libraries is in /guide/package-management/package-distribution.md. The link should be updated.
Suggested change
We also support the integration of code libraries maintained by other build systems such as Meson/Scons/Make. You only need to import the corresponding build auxiliary modules. I won’t go into details here. We can further check the documentation: [Integrate local third-party source code libraries ](/guide/package-management/using-official-packages)
We also support the integration of code libraries maintained by other build systems such as Meson/Scons/Make. You only need to import the corresponding build auxiliary modules. I won’t go into details here. We can further check the documentation: [Integrate local third-party source code libraries](/guide/package-management/package-distribution)

@waruqi waruqi merged commit c294689 into xmake-io:master Sep 25, 2025
4 of 5 checks passed
@Shiffted Shiffted deleted the fix-links branch November 2, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants