Skip to content

Conversation

@24bit-xjkp
Copy link
Contributor

  1. Some packages like FakeIt use <doctest.h>, so we need a copy of header files in the include dir

Hear is an example in FakeIt package. It use <doctest.h> directly, but the doctest package install <doctest.h> in the include/doctest directory, so a copy of <doctest.h> in include directory is nedded.

1. Some packages like `FakeIt` use <doctest.h>, so we need a copy of header files in the include dir
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @24bit-xjkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix to improve the compatibility of the doctest package with other projects that depend on it. By adjusting the installation process to copy doctest header files to a more accessible location, it ensures that dependent packages can correctly locate and include the necessary headers, thereby preventing build errors and streamlining integration.

Highlights

  • Header File Accessibility: Ensures that doctest header files, specifically doctest.h, are copied directly into the include directory during installation. This addresses an issue where some dependent packages, like FakeIt, expect to find doctest.h at the top level of the include path, rather than nested within a doctest subdirectory.
  • Compatibility Fix: Resolves a compatibility problem for projects that rely on the doctest testing framework but have specific expectations for header file locations, preventing build failures related to missing headers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where the doctest header is not found by packages that expect it in the root of the include directory. The change correctly addresses this by copying the header file. However, the implementation can be made more robust by being more specific about which file to copy, instead of using a wildcard. My review includes a suggestion to improve this.

@star-hengxing
Copy link
Contributor

We can add cmake install for config file installation.

@star-hengxing star-hengxing merged commit 4747248 into xmake-io:dev Sep 29, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants