-
-
Notifications
You must be signed in to change notification settings - Fork 487
fix(doctest): Copy headers to the include directory #8257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Some packages like `FakeIt` use <doctest.h>, so we need a copy of header files in the include dir
Summary of ChangesHello @24bit-xjkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a fix to improve the compatibility of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue where the doctest header is not found by packages that expect it in the root of the include directory. The change correctly addresses this by copying the header file. However, the implementation can be made more robust by being more specific about which file to copy, instead of using a wildcard. My review includes a suggestion to improve this.
|
We can add |
FakeItuse <doctest.h>, so we need a copy of header files in the include dirHear is an example in FakeIt package. It use
<doctest.h>directly, but the doctest package install<doctest.h>in theinclude/doctestdirectory, so a copy of<doctest.h>inincludedirectory is nedded.