brpc: fix build

[apocelipes]

Fixes #8033
Fixes #7211
Fixes #6254
Fixes #5651

[gemini-code-assist]

Summary of Changes

Hello @apocelipes, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the build stability and compatibility of the brpc package. It introduces support for a newer version (1.14.1) and applies critical adjustments to its build system. The changes specifically address linking issues with OpenSSL and resolve several macOS-specific linker errors by ensuring all necessary frameworks and symbols are correctly referenced during compilation.

Highlights

• BRPC Version Update: Added support for brpc version 1.14.1, including its source and a dedicated patch.
• OpenSSL Linking Fix: Introduced a patch to brpc's CMakeLists.txt to ensure the OPENSSL_CRYPTO_LIBRARY is correctly linked when OpenSSL is used without BoringSSL or Mesalink, resolving potential build failures.
• macOS Build Enhancements: Updated the xmake.lua configuration for macOS builds by adding the CoreData framework and including several -Wl,-U linker flags to resolve undefined symbol errors related to memory management, stack tracing, and Thrift protocol registration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the brpc package to version 1.14.1 and introduces several fixes to resolve build issues. A new patch is added for CMake to ensure OpenSSL libraries are linked correctly. The xmake.lua build script is updated for macOS by adding the CoreData framework and several linker flags to handle undefined symbols, which likely resolves linking errors. The changes appear correct and directly support the goal of fixing the build. My only feedback is a suggestion to improve the readability of the xmake.lua script by formatting the long lists of frameworks and linker flags over multiple lines.

[gemini-code-assist]

For better readability and maintainability, these function calls with many arguments can be split across multiple lines. This makes the lists of frameworks and linker flags easier to read and manage.

        add_frameworks(
            "Foundation",
            "CoreFoundation",
            "Security",
            "CoreGraphics",
            "CoreText",
            "CoreData"
        )
        add_ldflags(
            "-Wl,-U,_MallocExtension_ReleaseFreeMemory",
            "-Wl,-U,_ProfilerStart",
            "-Wl,-U,_ProfilerStop",
            "-Wl,-U,__Z13GetStackTracePPvii",
            "-Wl,-U,_RegisterThriftProtocol",
            "-Wl,-U,_mallctl",
            "-Wl,-U,_malloc_stats_print"
        )