Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 28, 2025

New version of cgal detected (package version: 6.0.2, last github version: 6.1)

@waruqi waruqi added the auto-update Automatic update label Oct 28, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the process of keeping the CGAL library dependency up-to-date. It specifically introduces support for the recently released version 6.1, ensuring that projects relying on this package can leverage the latest features and improvements.

Highlights

  • CGAL Version Update: The CGAL library package has been updated to version 6.1, adding support for this new release within the build system configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 6.1 for the cgal package. While the version addition is correct, it reveals a latent issue in the package's test configuration. The test needs to be updated to use C++17 for CGAL versions 6.0 and newer to prevent failures. I've added a specific comment regarding this. Additionally, I noticed some older version entries are not sorted, which could be addressed in a future PR for improved maintainability.

set_license("LGPL-3.0")

add_urls("https://github.com/CGAL/cgal/releases/download/v$(version)/CGAL-$(version)-library.zip")
add_versions("6.1", "d129a47329e7811b31b7343901fdb7b64d029b0cce262405fbebacd11f9b00dd")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The addition of version 6.1 requires an update to the test configuration. CGAL versions 6.0 and newer require C++17, but the current logic on line 79 selects C++14 for this new version. This will likely cause the test to fail.

Please update the on_test block to select the correct C++ standard based on the version. For example:

on_test(function (package)
    local lang = "c++11"
    if package:version():ge("6.0") then
        lang = "c++17"
    elseif package:version():ge("5.0.0") then
        lang = "c++14"
    end
    assert(package:check_cxxsnippets({test = [[...]]}, {configs = {languages = lang}, includes = {"CGAL/Epick_d.h", "CGAL/Delaunay_triangulation.h"}}))
end)

@github-actions github-actions bot merged commit 6eca0be into dev Oct 28, 2025
61 checks passed
@github-actions github-actions bot deleted the autoupdate-cgal-6.1 branch October 28, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants