Skip to content

Conversation

@toshi3221
Copy link

@toshi3221 toshi3221 commented Jun 1, 2018

Fixes

  • Fix Argument Exception when called logout(). 37469f7
    • currentPromise.resolve(new Object()); was called when LineLogin#logout is succeed. But Argument Exception was thrown.
  • Fix Exception calling promise multiple times when called another intent callback after calling logout(). 37469f7
    • When intent callback was listened, promise object was called. But the Promise object was not deleted after logging in, then Exception was thrown by being called multiple times when other intent calls.
  • Fix exception when the user denied the approval. e6b422a
    • Result code of loginResult when the user denied the approval is AUTHENTICATION_AGENT_ERROR. But NullPointerException was throwed because loginResult was set null.

I comfirmed React Native 0.54.4.

toshi3221 added 2 commits May 30, 2018 10:21
- Fix Argument Exception when called logout().
- Fix Exception calling promise multiple times when called another intent callback after calling logout().
@enrigalmig
Copy link
Member

Thanks for your contributions, we will review it and provide feedback 👍 cc: @xmartlabs/react

@santiagofm
Copy link

Thanks!

@santiagofm santiagofm merged commit ba16b98 into xmartlabs:master Jun 1, 2018
BondPiyapan pushed a commit to BondPiyapan/react-native-line-ex that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants