- 
                Notifications
    You must be signed in to change notification settings 
- Fork 95
Readme #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme #3
Conversation
|  | ||
| ## Requirements | ||
| - React native `0.48.+`. | ||
| - LineSDK iOS `4.0.3` and Android `4.0.6`. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about iOS requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean minimum iOS version?
        
          
                README.md
              
                Outdated
          
        
      | ## Installation | ||
| First, install the npm package and link it to your Android and iOS projects with react-native link. | ||
| ```bash | ||
| yarn add react-native-line | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can use npm as it is the default package manager for node. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sounds good
        
          
                README.md
              
                Outdated
          
        
      | 1. Follow all the configuration steps in [Line's Android integration guide](https://developers.line.me/en/docs/line-login/android/integrate-line-login/) | ||
| 2. Add the string `line_channel_id` to your strings file with the the channel id that you have on your line console. | ||
| ```xml | ||
| <string name="line_channel_id">Your channel id here</string> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add translatable="false"
Improvements
Just review the latest commit.