Skip to content

Conversation

@mcousillas6
Copy link

@mcousillas6 mcousillas6 commented Nov 2, 2017

Just review the latest commit.

  • Added docs on readme.
  • Added license file.


## Requirements
- React native `0.48.+`.
- LineSDK iOS `4.0.3` and Android `4.0.6`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about iOS requirements?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean minimum iOS version?

README.md Outdated
## Installation
First, install the npm package and link it to your Android and iOS projects with react-native link.
```bash
yarn add react-native-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use npm as it is the default package manager for node. Thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sounds good

README.md Outdated
1. Follow all the configuration steps in [Line's Android integration guide](https://developers.line.me/en/docs/line-login/android/integrate-line-login/)
2. Add the string `line_channel_id` to your strings file with the the channel id that you have on your line console.
```xml
<string name="line_channel_id">Your channel id here</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add translatable="false"

@mcousillas6 mcousillas6 merged commit b197929 into master Nov 3, 2017
@mcousillas6 mcousillas6 deleted the readme branch November 3, 2017 16:50
BondPiyapan pushed a commit to BondPiyapan/react-native-line-ex that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants