Skip to content

Conversation

@munkyu
Copy link
Contributor

@munkyu munkyu commented Feb 29, 2016

Unit testing framework like JUnit also shows the number of skipped test case. Therefore this function is required.

@codecov-io
Copy link

Current coverage is 98.59%

Merging #130 into master will not affect coverage as of a00433a

@@            master    #130   diff @@
======================================
  Files           17      17       
  Stmts         1065    1067     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1050    1052     +2
  Partial          0       0       
  Missed          15      15       

Review entire Coverage Diff as of a00433a

Powered by Codecov. Updated on successful CI builds.

@dnozay
Copy link
Member

dnozay commented Mar 2, 2016

  • There is an obvious typo in the commit
  • Can you please add a link to the schema definition you are using (junit xsd)?
  • Can you please copy-paste a sample xml report generated by another tool that uses the skipped field?

thank you

@munkyu munkyu changed the title Add the unmber of skipped testcase Add the number of skipped testcase Mar 2, 2016
@munkyu
Copy link
Contributor Author

munkyu commented Mar 2, 2016

I add dropbox links.

@munkyu
Copy link
Contributor Author

munkyu commented Mar 8, 2016

Please tell me if there is something to add or fix.

@dnozay
Copy link
Member

dnozay commented Mar 13, 2016

The schema definition you provided is not a schema definition; I am referring to the XSD file and how it defines which fields appear, and where they may appear. Also, a functional test to make sure the number of skips is accurate would be good to have before merging this.

@munkyu
Copy link
Contributor Author

munkyu commented Mar 14, 2016

@munkyu
Copy link
Contributor Author

munkyu commented Apr 4, 2016

You can also see sample JUnit XML file and JUnit XSD file on this web page. http://llg.cubic.org/docs/junit/
It describes that "skipped" is the total number of skipped tests.

dnozay added a commit that referenced this pull request Apr 5, 2016
@dnozay dnozay closed this Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants