Skip to content

Conversation

@danchr
Copy link
Contributor

@danchr danchr commented Sep 13, 2018

I tested with Python 2.7, 3.5 and 3.7, and at least --buffer works
everywhere. I was also missing a way to specify the output directory,
so I added the ability to do so.

This fixes #143 and closes #144.

(Please note that the change doesn't affect Python 2.7 as it uses a different approach to parsing arguments.)

@coveralls
Copy link

coveralls commented Sep 13, 2018

Coverage Status

Coverage increased (+0.01%) to 99.474% when pulling 15da886 on danchr:xmlrunner-output into d6d8734 on xmlrunner:master.

@danchr
Copy link
Contributor Author

danchr commented Sep 14, 2018

Coverage Status

Coverage decreased (-5.4%) to 94.065% when pulling 7e15783 on danchr:xmlrunner-output into 79621f3 on xmlrunner:master.

The cause of this is likely that the new code doesn't affect Python 2.7, and the coveralls setup doesn't try Python 3 😒

@danchr danchr force-pushed the xmlrunner-output branch 2 times, most recently from 31d29be to 9b17aad Compare November 13, 2018 17:42
I tested with Python 2.7, 3.5 and 3.7, and at least --buffer works
everywhere. I was also missing a way to specify the output directory,
so I added the ability to do so.

This fixes xmlrunner#143 and closes xmlrunner#144.
@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #174 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   99.46%   99.47%   +0.01%     
==========================================
  Files          17       17              
  Lines        1303     1334      +31     
==========================================
+ Hits         1296     1327      +31     
  Misses          7        7
Impacted Files Coverage Δ
xmlrunner/runner.py 100% <100%> (ø) ⬆️
tests/testsuite.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d8734...15da886. Read the comment docs.

@dnozay dnozay merged commit 8417e47 into xmlrunner:master Nov 27, 2018
@danchr danchr deleted the xmlrunner-output branch February 20, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add param to the module to set the output directory

4 participants