[IronPython] Fix for issue #182 - dont pass none to decode

[rasjani]

No description provided.

[codecov-io]

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          17       17           
  Lines        1382     1382           
=======================================
  Hits         1375     1375           
  Misses          7        7

Impacted Files	Coverage Δ
xmlrunner/result.py	98.34% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0703e1d...be5d6ec. Read the comment docs.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[coveralls]

Coverage remained the same at 99.493% when pulling be5d6ec on rasjani:fix-182 into 0703e1d on xmlrunner:master.

[dnozay]

@rasjani - thank you for the change, can you please add a test that highlights the broken behavior before the fix?

[rasjani]

Part of the issue is that it’s only reproduceable in IronPython so unless you run the unittests with it, there’s no issue and covering it might not make sense.

Also, since i've never used tox, getting run/verify things is a bit too much for me atm ..

Anyway, the point being, i'd assume something like this will trigger the issue:

from xmlrunner.result import safe_unicode
safe_unicode("a string")

and then the string passed to it has to go into branch here: https://github.com/xmlrunner/unittest-xml-reporting/blob/master/xmlrunner/result.py#L56

[dnozay]

see 6e4ef38