Use 'utf-8' encoding for exception info if there is no encoding set for sys.stdout #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or sys.stdout On some systems encoding for sys.stdout is defined but is None. In this case the default utf-8 is not used as getattr() will find the attrbute but because it is None, we get an exception when we try to encode a line.
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 99.47% 99.47% +<.01%
==========================================
Files 17 17
Lines 1524 1526 +2
==========================================
+ Hits 1516 1518 +2
Misses 8 8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 99.47% 99.47% +<.01%
==========================================
Files 17 17
Lines 1524 1526 +2
==========================================
+ Hits 1516 1518 +2
Misses 8 8
Continue to review full report at Codecov.
|
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems encoding for sys.stdout is defined but is None. In this case the default utf-8 is not used as getattr() will find the attrbute but because it is None, we get an exception when we try to encode a line.