Skip to content

Conversation

@hoefling
Copy link
Member

A better approach than in #175 is to reinstall error callback after xmlSecCryptoInit() invocation. This will also increase test coverage a bit more.

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #178 (94f0fef) into master (efced9f) will increase coverage by 0.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   90.76%   91.64%   +0.87%     
==========================================
  Files          12       12              
  Lines        2046     2046              
==========================================
+ Hits         1857     1875      +18     
+ Misses        189      171      -18     
Impacted Files Coverage Δ
src/main.c 78.49% <100.00%> (+19.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efced9f...94f0fef. Read the comment docs.

@hoefling hoefling merged commit 2f28106 into xmlsec:master May 28, 2021
@hoefling hoefling deleted the pyxmlsec-error-callback-2 branch May 29, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants