Skip to content

https://github.com/xmlunit/xmlunit/issues/307 doesn't seem to happen … #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

https://github.com/xmlunit/xmlunit/issues/307 doesn't seem to happen … #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/tests/net-core/Diff/DOMDifferenceEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,6 +1171,33 @@ public void XPathKnowsAboutNodeFiltersForUnmatchedTestNodes() {
Assert.AreEqual("/Document[1]/Section[1]", diff.Differences.Last().Comparison.ControlDetails.ParentXPath);
}

[Test]
public void ProperlyHandlesNullAttributes() {
DOMDifferenceEngine d = new DOMDifferenceEngine();
DiffExpecter ex = new DiffExpecter(ComparisonType.ATTR_VALUE);
d.DifferenceListener += ex.ComparisonPerformed;
d.ComparisonController = ComparisonControllers.StopWhenDifferent;

XmlElement e1 = doc.CreateElement("foo");
e1.SetAttribute("x", null);
XmlElement e2 = doc.CreateElement("foo");
e2.SetAttribute("x", null);
XmlElement e3 = doc.CreateElement("foo");
e3.SetAttribute("x", "2137");
XmlElement e4 = doc.CreateElement("foo");
e4.SetAttribute("x", string.Empty);

Assert.AreEqual(Wrap(ComparisonResult.EQUAL),
d.CompareNodes(e1, new XPathContext(),
e2, new XPathContext()));
Assert.AreEqual(WrapAndStop(ComparisonResult.DIFFERENT),
d.CompareNodes(e1, new XPathContext(),
e3, new XPathContext()));
Assert.AreEqual(Wrap(ComparisonResult.EQUAL),
d.CompareNodes(e1, new XPathContext(),
e4, new XPathContext()));
}

private XmlDocument DocumentForString(string s) {
return Org.XmlUnit.Util.Convert.ToDocument(InputBuilder.FromString(s).Build());
}
Expand Down