Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a yarn install step to the
validate-regressionGitHub Actions workflow and update agent configuration to use onlyActionsCodecandIntentCodecwhile defaulting SDK exports to@xmtp/agent-sdk1.1.10Update the regression workflow to install dependencies with
yarn installbefore running tests, reduce the agent codecs toActionsCodecandIntentCodecinAgent.createFromEnv, extend tagged message logging withctx.getSenderAddress(), and shift SDK exports and aliases to@xmtp/agent-sdk1.1.10 with versions 1.1.7 and 1.1.2 available.📍Where to Start
Start with the agent configuration changes in index.ts, then review version export updates in agent-sdk.ts, and finally the workflow step in validate-regression.yml.
📊 Macroscope summarized baf74f2. 2 files reviewed, 4 issues evaluated, 4 issues filtered, 0 comments posted
🗂️ Filtered Issues
agents/bots/key-check/index.ts — 0 comments posted, 2 evaluated, 2 filtered
Agent.createFromEnvexpects a baseline text/markdown codec to be present (for system messages, fallbacks, or default decoding), reducingcodecsto onlyActionsCodecandIntentCodeccan cause agent startup to fail or lead to exceptions when processing basic messages. This is a plausible runtime bug given the previously includedMarkdownCodec. [ Low confidence ]codecsarray was reduced to[new ActionsCodec(), new IntentCodec()], removing previously supported codecsMarkdownCodec,ReactionCodec,ReplyCodec,RemoteAttachmentCodec,AttachmentCodec, andWalletSendCallsCodec. If the agent receives or needs to emit messages using any of these content types (which were previously supported), it will be unable to decode/encode them. Depending onAgent.createFromEnvand the agent's message handling pipeline, this can result in runtime failures such as unrecognized content type errors, dropped messages, or failure to process basic text/markdown messages. This is a visible behavior change and breaks parity with the earlier externally visible contract for supported content types. [ Low confidence ]agents/versions/agent-sdk.ts — 0 comments posted, 2 evaluated, 2 filtered
process.env.AGENT_SDK_VERSIONwill throw in non-Node environments whereprocessis undefined (e.g., many browser builds without a shim). Theif (process.env.AGENT_SDK_VERSION)guard still dereferencesprocess.env, causing a ReferenceError. Guard the existence ofprocessandprocess.envbefore reading, or use a cross-environment configuration mechanism. [ Out of scope ]getActiveAgentVersioncan returnundefinedwhenindexis out of bounds or whengetAgentVersions()returns an empty array (e.g., if no entries haveauto: true). This leads to an ambiguous return value with no error thrown, and downstream consumers expecting a valid version object may crash. Guard against out-of-range indexes and empty lists, or throw a clear error when no version exists for the requested index. [ Out of scope ]