Skip to content

Conversation

@humanagent
Copy link
Collaborator

@humanagent humanagent commented Nov 5, 2025

Add a yarn install step to the validate-regression GitHub Actions workflow and update agent configuration to use only ActionsCodec and IntentCodec while defaulting SDK exports to @xmtp/agent-sdk 1.1.10

Update the regression workflow to install dependencies with yarn install before running tests, reduce the agent codecs to ActionsCodec and IntentCodec in Agent.createFromEnv, extend tagged message logging with ctx.getSenderAddress(), and shift SDK exports and aliases to @xmtp/agent-sdk 1.1.10 with versions 1.1.7 and 1.1.2 available.

📍Where to Start

Start with the agent configuration changes in index.ts, then review version export updates in agent-sdk.ts, and finally the workflow step in validate-regression.yml.


📊 Macroscope summarized baf74f2. 2 files reviewed, 4 issues evaluated, 4 issues filtered, 0 comments posted

🗂️ Filtered Issues

agents/bots/key-check/index.ts — 0 comments posted, 2 evaluated, 2 filtered
  • line 299: Potential initialization/runtime failure: If Agent.createFromEnv expects a baseline text/markdown codec to be present (for system messages, fallbacks, or default decoding), reducing codecs to only ActionsCodec and IntentCodec can cause agent startup to fail or lead to exceptions when processing basic messages. This is a plausible runtime bug given the previously included MarkdownCodec. [ Low confidence ]
  • line 299: Contract parity/regression: The codecs array was reduced to [new ActionsCodec(), new IntentCodec()], removing previously supported codecs MarkdownCodec, ReactionCodec, ReplyCodec, RemoteAttachmentCodec, AttachmentCodec, and WalletSendCallsCodec. If the agent receives or needs to emit messages using any of these content types (which were previously supported), it will be unable to decode/encode them. Depending on Agent.createFromEnv and the agent's message handling pipeline, this can result in runtime failures such as unrecognized content type errors, dropped messages, or failure to process basic text/markdown messages. This is a visible behavior change and breaks parity with the earlier externally visible contract for supported content types. [ Low confidence ]
agents/versions/agent-sdk.ts — 0 comments posted, 2 evaluated, 2 filtered
  • line 57: Unconditional access to process.env.AGENT_SDK_VERSION will throw in non-Node environments where process is undefined (e.g., many browser builds without a shim). The if (process.env.AGENT_SDK_VERSION) guard still dereferences process.env, causing a ReferenceError. Guard the existence of process and process.env before reading, or use a cross-environment configuration mechanism. [ Out of scope ]
  • line 67: getActiveAgentVersion can return undefined when index is out of bounds or when getAgentVersions() returns an empty array (e.g., if no entries have auto: true). This leads to an ambiguous return value with no error thrown, and downstream consumers expecting a valid version object may crash. Guard against out-of-range indexes and empty lists, or throw a clear error when no version exists for the requested index. [ Out of scope ]

@humanagent humanagent merged commit 372b82a into main Nov 5, 2025
3 checks passed
@humanagent humanagent deleted the humanagent/feature-20251104-210934 branch November 5, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants