-
Notifications
You must be signed in to change notification settings - Fork 9
Digest signed package fixes #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return t.fileName | ||
| } | ||
|
|
||
| func (t *TarGzip) Size() int64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just use fi, err := os.Stat(t.Name()) instead of opening and closing the file.
digest_test.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| // "fmt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you dont use fmt, just remove it.
|
Changes Unknown when pulling 1ecf83a on digest-fixes into ** on master**. |
|
Changes Unknown when pulling 1ecf83a on digest-fixes into ** on master**. |
|
Changes Unknown when pulling 46f4cd1 on digest-fixes into ** on master**. |
|
Travis an Appveyor are failing furthermore LGTM |
|
Changes Unknown when pulling fede7bc on digest-fixes into ** on master**. |
…t with 100x (88secs -> 3.5secs)
|
Changes Unknown when pulling e557383 on digest-fixes into ** on master**. |
|
Changes Unknown when pulling 3d53701 on digest-fixes into ** on master**. |
|
Changes Unknown when pulling 3d53701 on digest-fixes into ** on master**. |
|
Appveyor and travis have been fixed. Only appveyor tests now with race detector on, because these workers are faster (travis takes approx 220sec, while appveyor 100sec). |
|
You're the boss. I think data-race detection should be on by default everywhere and disable it when you can't wait. CI results is never real-time needed. |
Re-enables package signing, but doesn't work yet.