Skip to content

Conversation

@xor-gate
Copy link
Owner

Re-enables package signing, but doesn't work yet.

@xor-gate xor-gate requested a review from rikvdh June 26, 2017 21:10
return t.fileName
}

func (t *TarGzip) Size() int64 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use fi, err := os.Stat(t.Name()) instead of opening and closing the file.

digest_test.go Outdated

import (
"fmt"
// "fmt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you dont use fmt, just remove it.

@coveralls
Copy link

coveralls commented Jun 26, 2017

Coverage Status

Changes Unknown when pulling 1ecf83a on digest-fixes into ** on master**.

@coveralls
Copy link

coveralls commented Jun 26, 2017

Coverage Status

Changes Unknown when pulling 1ecf83a on digest-fixes into ** on master**.

@coveralls
Copy link

coveralls commented Jun 26, 2017

Coverage Status

Changes Unknown when pulling 46f4cd1 on digest-fixes into ** on master**.

@rikvdh
Copy link
Collaborator

rikvdh commented Jun 27, 2017

Travis an Appveyor are failing furthermore LGTM

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Changes Unknown when pulling fede7bc on digest-fixes into ** on master**.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Changes Unknown when pulling e557383 on digest-fixes into ** on master**.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Changes Unknown when pulling 3d53701 on digest-fixes into ** on master**.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Changes Unknown when pulling 3d53701 on digest-fixes into ** on master**.

@xor-gate
Copy link
Owner Author

Appveyor and travis have been fixed. Only appveyor tests now with race detector on, because these workers are faster (travis takes approx 220sec, while appveyor 100sec).

@rikvdh
Copy link
Collaborator

rikvdh commented Jun 27, 2017

You're the boss. I think data-race detection should be on by default everywhere and disable it when you can't wait. CI results is never real-time needed.

@rikvdh rikvdh merged commit 9b4b162 into master Jun 27, 2017
@rikvdh rikvdh deleted the digest-fixes branch June 27, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants