Skip to content

Conversation

@rikvdh
Copy link
Collaborator

@rikvdh rikvdh commented May 28, 2017

No description provided.

@rikvdh rikvdh requested a review from xor-gate May 28, 2017 17:38
@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+2.6%) to 77.247% when pulling 7abb6dd on config-updates into bff4031 on master.

@rikvdh
Copy link
Collaborator Author

rikvdh commented May 28, 2017

Build is fine, Travis horks on the coveralls thing.

config.go Outdated
@@ -1,4 +1,4 @@
// Copyright 2016 Jerry Jacobs. All rights reserved.
// Copyright 2017 Jerry Jacobs & Rik van der Heijden. All rights reserved.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe debpkg authors, with a AUTHORS file?

@@ -0,0 +1,76 @@
package debpkg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add copyright header

@coveralls
Copy link

Coverage Status

Coverage increased (+4.2%) to 78.81% when pulling 57e3ba7 on config-updates into bff4031 on master.

2 similar comments
@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+4.2%) to 78.81% when pulling 57e3ba7 on config-updates into bff4031 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.2%) to 78.81% when pulling 57e3ba7 on config-updates into bff4031 on master.

@xor-gate
Copy link
Owner

LGTM, updating the year of copyright is not necessary see:

https://golang.org/doc/contribute.html#copyright

Files in the repository are copyright the year they are added. Do not update the copyright year on files that you change.

@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+2.9%) to 77.457% when pulling 6397bb6 on config-updates into bff4031 on master.

@xor-gate
Copy link
Owner

@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+2.9%) to 77.457% when pulling 6397bb6 on config-updates into bff4031 on master.

@xor-gate
Copy link
Owner

Maybe we would like the same style copyright header and LICENSE file first line as the go project with this PR

@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+2.1%) to 76.705% when pulling 4721283 on config-updates into bff4031 on master.

@coveralls
Copy link

coveralls commented May 28, 2017

Coverage Status

Coverage increased (+2.1%) to 76.705% when pulling 478aec7 on config-updates into bff4031 on master.

@xor-gate xor-gate merged commit c27fbc2 into master May 28, 2017
@xor-gate xor-gate deleted the config-updates branch May 28, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants