Tempfiles for data.tar.gz and control.tar.gz #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xor-gate
changed the title
Owner
Author
|
ping @rikvdh |
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
…a1), less verbose dpkg test
rikvdh
reviewed
Jun 26, 2017
| // SetTempDir sets the temporary directory for intermediate files. When the directory doesn't | ||
| // exist it is automaticly created. The caller is responsible for the cleanup of tempdir. | ||
| func SetTempDir(dir string) error { | ||
| if dir == "" { |
Collaborator
There was a problem hiding this comment.
When the directory is emtpy you take the empty-directory as TempDir? Don't you want to get the system-wide temp-dir with os.TempDir()?
Owner
Author
There was a problem hiding this comment.
empty Directory is automatic os.TempDir, see os.TempFile
rikvdh
requested changes
Jun 26, 2017
control.go
Outdated
| c.info.maintainer, | ||
| c.info.maintainerEmail) | ||
| o += fmt.Sprintf("Installed-Size: %d\n", installedSize) | ||
| o += fmt.Sprintf("Installed-Size: %d\n", uint64(math.Floor((float64(installedSize)/1024)+0.5))) |
Collaborator
There was a problem hiding this comment.
Just use math.Ceil() without the floor(x+0.5) which is also wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on tempfiles for data.tar.gz and control.tar.gz when packaging exceed RAM size.