fix(health): update service health check to return healthy status for registered services

juicycleff · juicycleff · commit 0adf2682dbdb · 2026-04-13T11:37:57.000-05:00
diff --git a/cmd/forge/go.mod b/cmd/forge/go.mod
@@ -90,7 +90,7 @@ require (
 	github.com/xdg-go/stringprep v1.0.4 // indirect
 	github.com/xraph/confy v0.5.0 // indirect
 	github.com/xraph/go-utils v1.1.1 // indirect
-	github.com/xraph/vessel v1.0.1 // indirect
+	github.com/xraph/vessel v1.0.2 // indirect
 	github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78 // indirect
 	go.mongodb.org/mongo-driver v1.17.4 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
diff --git a/cmd/forge/go.sum b/cmd/forge/go.sum
@@ -308,8 +308,8 @@ github.com/xraph/confy v0.5.0 h1:7dK3hx3MQKlNPK9mFSm07iyU05kUnx6um8d86/gyajg=
 github.com/xraph/confy v0.5.0/go.mod h1:/uhVfKibPR+kn7MI9LkVVekk84NP0sxsKZ9sFQoQ5Kc=
 github.com/xraph/go-utils v1.1.1 h1:k5TOQ1qhXLdEX8W5F60mSuPcFOPc8sBsnhmjx/Kpr5g=
 github.com/xraph/go-utils v1.1.1/go.mod h1:tZN4SuGy9otCo6dETp7Cvkgyiy0BvaJaZbTBv4Euvo4=
-github.com/xraph/vessel v1.0.1 h1:A3T3cE3ze/FYjyyXarmgcWofbmXbB2SdxRs9uF71k/E=
-github.com/xraph/vessel v1.0.1/go.mod h1:5hgrMbuczxu2kRIM3iVJ3wPSb6HOvbMhV4nkRFaPNqs=
+github.com/xraph/vessel v1.0.2 h1:IeNTwxiFgqH2vW9lh8PNXr1SeGdEc7cxQ6sH7jMokfo=
+github.com/xraph/vessel v1.0.2/go.mod h1:5hgrMbuczxu2kRIM3iVJ3wPSb6HOvbMhV4nkRFaPNqs=
 github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78 h1:ilQV1hzziu+LLM3zUTJ0trRztfwgjqKnBWNtSRkbmwM=
 github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78/go.mod h1:aL8wCCfTfSfmXjznFBSZNN13rSJjlIOI1fUNAtF7rmI=
 github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
diff --git a/extensions/cache/go.mod b/extensions/cache/go.mod
@@ -8,7 +8,7 @@ require (
 	github.com/stretchr/testify v1.11.1
 	github.com/xraph/confy v0.5.0
 	github.com/xraph/forge v1.4.4
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/consensus/go.mod b/extensions/consensus/go.mod
@@ -8,7 +8,7 @@ require (
 	github.com/dgraph-io/badger/v4 v4.8.0
 	github.com/hashicorp/consul/api v1.33.0
 	github.com/xraph/forge v1.4.4
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 	go.etcd.io/bbolt v1.4.3
 	google.golang.org/grpc v1.78.0
 	google.golang.org/protobuf v1.36.11
diff --git a/extensions/cron/go.mod b/extensions/cron/go.mod
@@ -8,7 +8,7 @@ require (
 	github.com/google/uuid v1.6.0
 	github.com/robfig/cron/v3 v3.0.1
 	github.com/xraph/forge v1.4.4
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 	gopkg.in/yaml.v3 v3.0.1
 )
 
diff --git a/extensions/database/go.mod b/extensions/database/go.mod
@@ -18,7 +18,7 @@ require (
 	github.com/uptrace/bun/dialect/sqlitedialect v1.2.15
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/go-utils v1.1.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 	go.mongodb.org/mongo-driver v1.17.4
 )
 
diff --git a/extensions/kafka/go.mod b/extensions/kafka/go.mod
@@ -7,7 +7,7 @@ require (
 	github.com/xdg-go/scram v1.1.2
 	github.com/xraph/confy v0.5.0
 	github.com/xraph/forge v1.4.4
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/mcp/go.mod b/extensions/mcp/go.mod
@@ -6,7 +6,7 @@ require (
 	github.com/xraph/confy v0.5.0
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/go-utils v1.1.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/mqtt/go.mod b/extensions/mqtt/go.mod
@@ -6,7 +6,7 @@ require (
 	github.com/eclipse/paho.mqtt.golang v1.5.0
 	github.com/xraph/confy v0.5.0
 	github.com/xraph/forge v1.5.0
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/orpc/go.mod b/extensions/orpc/go.mod
@@ -4,7 +4,7 @@ go 1.25.7
 
 require (
 	github.com/xraph/forge v1.2.0
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/queue/go.mod b/extensions/queue/go.mod
@@ -8,7 +8,7 @@ require (
 	github.com/redis/go-redis/v9 v9.14.1
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/forge/extensions/database v0.0.0-00010101000000-000000000000
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/search/go.mod b/extensions/search/go.mod
@@ -4,7 +4,7 @@ go 1.25.7
 
 require (
 	github.com/xraph/forge v1.4.4
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/security/go.mod b/extensions/security/go.mod
@@ -6,7 +6,7 @@ require (
 	github.com/golang-jwt/jwt/v5 v5.3.0
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/go-utils v1.1.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 	golang.org/x/crypto v0.47.0
 )
 
diff --git a/extensions/storage/go.mod b/extensions/storage/go.mod
@@ -10,7 +10,7 @@ require (
 	github.com/aws/aws-sdk-go-v2/service/s3 v1.88.6
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/go-utils v1.1.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/extensions/streaming/go.mod b/extensions/streaming/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/redis/go-redis/v9 v9.14.1
 	github.com/xraph/forge v1.4.4
 	github.com/xraph/forgeui v1.4.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 )
 
 require (
diff --git a/go.mod b/go.mod
@@ -20,7 +20,7 @@ require (
 	github.com/xraph/confy v0.5.0
 	github.com/xraph/forgeui v1.4.1
 	github.com/xraph/go-utils v1.1.1
-	github.com/xraph/vessel v1.0.1
+	github.com/xraph/vessel v1.0.2
 	go.opentelemetry.io/otel v1.40.0
 	go.opentelemetry.io/otel/exporters/jaeger v1.17.0
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.40.0
diff --git a/internal/health/checks.go b/internal/health/checks.go
@@ -137,9 +137,12 @@ func (hc *ManagerImpl) checkServiceHealth(ctx context.Context, serviceName strin
 
 	service, err := container.Resolve(serviceName)
 	if err != nil {
-		return healthinternal.NewHealthResult(serviceName, healthinternal.HealthStatusUnhealthy, "failed to resolve service").
-			WithError(err).
-			WithDetail("service_name", serviceName)
+		// Service is known to the container (returned by Services()) but
+		// cannot be resolved by name — common for type-registry services
+		// registered via Provide(). Default to healthy since the service
+		// is registered and running. This is consistent with
+		// ManagerImpl.checkService() in manager.go.
+		return healthinternal.NewHealthResult(serviceName, healthinternal.HealthStatusHealthy, "service registered")
 	}
 
 	// Check if service implements the OnHealthCheck method

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ require (`
`8`	`8`	`github.com/stretchr/testify v1.11.1`
`9`	`9`	`github.com/xraph/confy v0.5.0`
`10`	`10`	`github.com/xraph/forge v1.4.4`
`11`		`- github.com/xraph/vessel v1.0.1`
	`11`	`+ github.com/xraph/vessel v1.0.2`
`12`	`12`	`)`
`13`	`13`
`14`	`14`	`require (`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ require (`
`8`	`8`	`github.com/google/uuid v1.6.0`
`9`	`9`	`github.com/robfig/cron/v3 v3.0.1`
`10`	`10`	`github.com/xraph/forge v1.4.4`
`11`		`- github.com/xraph/vessel v1.0.1`
	`11`	`+ github.com/xraph/vessel v1.0.2`
`12`	`12`	`gopkg.in/yaml.v3 v3.0.1`
`13`	`13`	`)`
`14`	`14`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ require (`
`18`	`18`	`github.com/uptrace/bun/dialect/sqlitedialect v1.2.15`
`19`	`19`	`github.com/xraph/forge v1.4.4`
`20`	`20`	`github.com/xraph/go-utils v1.1.1`
`21`		`- github.com/xraph/vessel v1.0.1`
	`21`	`+ github.com/xraph/vessel v1.0.2`
`22`	`22`	`go.mongodb.org/mongo-driver v1.17.4`
`23`	`23`	`)`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ require (`
`7`	`7`	`github.com/xdg-go/scram v1.1.2`
`8`	`8`	`github.com/xraph/confy v0.5.0`
`9`	`9`	`github.com/xraph/forge v1.4.4`
`10`		`- github.com/xraph/vessel v1.0.1`
	`10`	`+ github.com/xraph/vessel v1.0.2`
`11`	`11`	`)`
`12`	`12`
`13`	`13`	`require (`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ require (`
`6`	`6`	`github.com/xraph/confy v0.5.0`
`7`	`7`	`github.com/xraph/forge v1.4.4`
`8`	`8`	`github.com/xraph/go-utils v1.1.1`
`9`		`- github.com/xraph/vessel v1.0.1`
	`9`	`+ github.com/xraph/vessel v1.0.2`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`require (`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ require (`
`6`	`6`	`github.com/eclipse/paho.mqtt.golang v1.5.0`
`7`	`7`	`github.com/xraph/confy v0.5.0`
`8`	`8`	`github.com/xraph/forge v1.5.0`
`9`		`- github.com/xraph/vessel v1.0.1`
	`9`	`+ github.com/xraph/vessel v1.0.2`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`require (`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ go 1.25.7`
`4`	`4`
`5`	`5`	`require (`
`6`	`6`	`github.com/xraph/forge v1.2.0`
`7`		`- github.com/xraph/vessel v1.0.1`
	`7`	`+ github.com/xraph/vessel v1.0.2`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`require (`