Skip to content

Conversation

@kynrai
Copy link
Collaborator

@kynrai kynrai commented Jun 14, 2024

  • Move block list logic to checks
  • Create IP resolver interfaces
    • Inject resolvers
  • Add code cov file for code that just calls stdlib

- Move block list logic to checks
- Create IP resolver interfaces
  - Inject resolvers
- Add code cov file for code that just calls stdlib
@kynrai kynrai requested a review from Lissy93 as a code owner June 14, 2024 13:38
@codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 59.75% <86.04%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/server.go 84.21% <100.00%> (ø)
checks/block_lists.go 94.59% <94.59%> (ø)
checks/checks.go 0.00% <0.00%> (ø)
handlers/block_lists.go 75.00% <33.33%> (-19.12%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kynrai kynrai merged commit 97fbfce into main Jun 15, 2024
@kynrai kynrai deleted the rf/block_lists branch June 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants