Skip to content

Conversation

@syywu
Copy link
Contributor

@syywu syywu commented Jun 14, 2024

  • Refactored and moved headers logic to checks
  • Removed valid url test as the same logic is tested in checks/headers_test.go

@syywu syywu requested a review from Lissy93 as a code owner June 14, 2024 14:06
@syywu syywu changed the title RF: Headers RF: headers Jun 14, 2024
@codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 52.64% <68.42%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
handlers/headers.go 100.00% <100.00%> (+16.66%) ⬆️
checks/checks.go 0.00% <0.00%> (ø)
server/server.go 0.00% <0.00%> (ø)
checks/headers.go 73.33% <73.33%> (ø)

Copy link
Member

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I really like this - thanks for the contribution 💜

@Lissy93 Lissy93 merged commit 4fc4787 into xray-web:main Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants