Build error on Apple M1

[AlenkaF]

When building Arrow C++ I get an error with this traceback:

ninja -j4
ninja install
popd
[80/550] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/validate.cc.o
FAILED: src/arrow/CMakeFiles/arrow_objlib.dir/array/validate.cc.o 
/opt/homebrew/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DARROW_EXPORTING -DARROW_HAVE_NEON -DARROW_HDFS -DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DURI_STATIC_BUILD -DUTF8PROC_STATIC -I/Users/alenkafrim/repos/arrow/cpp/build/src -I/Users/alenkafrim/repos/arrow/cpp/src -I/Users/alenkafrim/repos/arrow/cpp/src/generated -isystem /Users/alenkafrim/repos/arrow/cpp/thirdparty/flatbuffers/include -isystem /opt/homebrew/include -isystem /Users/alenkafrim/repos/arrow/cpp/build/jemalloc_ep-prefix/src -isystem /Users/alenkafrim/repos/arrow/cpp/build/googletest_ep-prefix/include -isystem /opt/homebrew/Cellar/rapidjson/1.1.0/include -isystem /Users/alenkafrim/repos/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include -isystem /Users/alenkafrim/repos/arrow/cpp/build/utf8proc_ep-install/include -isystem /Users/alenkafrim/repos/arrow/cpp/thirdparty/hadoop/include -Qunused-arguments -fcolor-diagnostics -O3 -DNDEBUG  -Wall -Wno-unknown-warning-option -Wno-pass-failed -stdlib=libc++ -march=armv8-a  -O3 -DNDEBUG -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -fPIC -std=c++11 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/array/validate.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/array/validate.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/array/validate.cc.o -c /Users/alenkafrim/repos/arrow/cpp/src/arrow/array/validate.cc
In file included from /Users/alenkafrim/repos/arrow/cpp/src/arrow/array/validate.cc:32:
In file included from /Users/alenkafrim/repos/arrow/cpp/src/arrow/util/utf8.h:27:
In file included from /Users/alenkafrim/repos/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include/xsimd/xsimd.hpp:22:
In file included from /Users/alenkafrim/repos/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include/xsimd/types/./xsimd_batch.hpp:422:
In file included from /Users/alenkafrim/repos/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include/xsimd/types/../arch/xsimd_isa.hpp:64:
/Users/alenkafrim/repos/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include/xsimd/types/../arch/./xsimd_neon.hpp:630:55: error: constexpr variable 'dispatcher' must be initialized by a constant expression
            constexpr detail::neon_dispatcher::binary dispatcher =
                                                      ^
.
.
.

I am building on M1 MacOs:

• MacOs Big Sur Version 11.6
• Xcode 13.0
• Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
• Apple clang version 13.0.0 (clang-1300.0.29.3)
• Target: arm64-apple-darwin20.6.0
• Thread model: posix

cc @pitrou

[pitrou]

cc @cyb70289

[serge-sans-paille]

Can you confirm #604 fixes the issue?

[pitrou]

It would probably be non-trivial to test before you merge that PR and we update our vendoring targets, so no need to wait for us. The fix looks entirely reasonable.

[cyb70289]

I've tested on apple m1. There's another issue in neon64.hpp. #606 fixes it.