Skip to content

Conversation

@serge-sans-paille
Copy link
Contributor

No description provided.

@serge-sans-paille serge-sans-paille changed the title Bug/1132 generalization of reduce_mul implementation Aug 23, 2025
@serge-sans-paille
Copy link
Contributor Author

serge-sans-paille commented Aug 23, 2025

Note to self: we should provide dedicated reduction for or, and and xor operator, and do it in a generic way if possible. RISCV supports those reductions.

It matches the implementation of other operations.
This is a generalization of #1132 by @emrys53. Part of the Intel code is
strongly inspired by the work from #1132, with some minor nits.
res += val;
}
return res;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this means the next release should be a major one. On the other hand, since reduce_add was already available, I wonder if this function was really used.

@JohanMabille JohanMabille merged commit eb3bacb into master Aug 29, 2025
130 checks passed
@JohanMabille JohanMabille deleted the bug/1132 branch August 29, 2025 15:46
@serge-sans-paille
Copy link
Contributor Author

serge-sans-paille commented Aug 29, 2025 via email

@JohanMabille
Copy link
Member

Ah indeed, so we're good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants