-
Notifications
You must be signed in to change notification settings - Fork 280
Add 8/16 bits AVX2 swizzle #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8/16 bits AVX2 swizzle #1197
Conversation
|
looking at the build failure on x86_64, you need to add some |
|
Or could it be that I should add the 8/16 bits overload as batch constants as well (which we'd also want)? |
6d42208 to
27e1813
Compare
|
Seems like the failure is already on main. |
|
Looks good, squash everything with a nice commit message and we're good to go! |
include/xsimd/arch/xsimd_avx2.hpp
Outdated
|
|
||
| // swizzle (constant mask) | ||
| template < | ||
| class A, typename T, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could you use a variadic argument count here and just static_assert on the count? (here and the function below).
28e1c8d to
3eecf19
Compare
|
@serge-sans-paille you should be able to squash-merge directly from the Github UI once ready. |
4393266
into
xtensor-stack:master
|
@AntoinePrv : I've done it but I generally prefer when the author creates a consistent commit message during the squash: the author knows better! |
Add 8 and 16 bits AVX2 swizzle implementation.
These two sizes are not available on AVX.
Algorithm very similar to GH-1189.