Added load / store / broadcast APIs #596
Conversation
| template <class To, class A=default_arch, class From> | ||
| void store_batch(To* dst, batch<From, A> const& src, aligned_mode) { | ||
| kernel::store_aligned(dst, src, A{}); | ||
| } |
There was a problem hiding this comment.
What is the use of such aliases, We already provide xsimd::store that does exactly the same. If that's for backward compatibility, then I'd suggest using the __attribute__((deprecated(reason)) attribute.
There was a problem hiding this comment.
This one is for symmetry with load_batch, which is slightly different form the load methods.
There was a problem hiding this comment.
another solution would be to replace the current load_xxx with the new implementation, andmake the current store implementation symmetric. And I discard the load_batch / store_batch methods. What do you think @serge-sans-paille ?
JohanMabille
force-pushed
the
api
branch
5 times, most recently
from
67628bf to
f318db9
Compare
| * @return a new batch instance | ||
| */ | ||
| template <class To, class A=default_arch, class From> | ||
| simd_return_type<From, To> broadcast_as(From v) { |
There was a problem hiding this comment.
maybe we should static_assert that From and To are different and redirect to the right function otherwise?
There was a problem hiding this comment.
I don't think so, because as a user you don't want to have to check whether the types are equivalent or not, and invoke a function or another one depending on that. The user can do it, but we should not impose it.
There was a problem hiding this comment.
ok. Looks good otherwise, feel free to merge.
2 participants
@serge-sans-paille these are the last APIs missing in xsimd and that we need in xtensor.
Once this is merged, we can release ;)