Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few minor issues for
xtensor-blas:xtensor_INCLUDE_DIRshould probably be namedxtensor_INCLUDE_DIRS?CMAKE_BUILD_TYPEshould only be overwritten if not explicitly set by the userfind_package(xtensor REQUIRED)in https://github.com/xtensor-stack/xtensor-blas/compare/master...BioDataAnalysis:emmenlau_minor_cmake_fixes?expand=1#diff-15547c54d3d4898a882b4ab7b3cee381L113 leads to compile errors like: