Added support for cmake 3.17 to test/set_compiler_flag.cmake #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think at least some of the failling builds are unrelated, so I hope this change does not break anything. |
Member
|
For a reason I don't understand, conda now install openblas 0.3.6 by default instead of 0.3.7. I really don't have the time to investigate why, so I forced the version to 0.3.7 in #154. I think that rebasing your PR on master should ifx the issue. |
emmenlau
force-pushed
the
bda_improve_cmake_3_17_support
branch
from
3cf7fa8 to
e39affa
Compare
Contributor
Author
Thanks! I'm testing this now as we speak... |
Contributor
Author
|
Ok this looks indeed better... thanks @JohanMabille |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cmake 3.17-rc1 the compiler checks for MSVC fails. This is because the flag
_flag_worksis unset withunset(_flag_works CACHE)which is not sufficient. It must also be unset without theCACHEoption.