Skip to content

Conversation

@irokas
Copy link
Contributor

@irokas irokas commented Jul 2, 2017

I was not able to implement a test because I could not get jsdom to work in test.js.

@Tyriar Any ideas on how I can write this test?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 69.651% when pulling 60348d1 on irokas:Rows-fix into 31aab8e on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 69.651% when pulling 0a5d7a7 on irokas:Rows-fix into 31aab8e on sourcelair:master.

@Tyriar
Copy link
Member

Tyriar commented Jul 4, 2017

@irokas yeah there aren't any tests for resize yet, hopefully we can get around to better testing on the Terminal class when the TypeScript migration finishes.

@Tyriar Tyriar self-assigned this Jul 4, 2017
@Tyriar Tyriar added this to the 2.8.0 milestone Jul 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 69.637% when pulling af0030b on irokas:Rows-fix into 934ca65 on sourcelair:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants